Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

conjure-tor: init at 0-unstable-2024-11-11 #367417

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mksafavi
Copy link
Contributor

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@mksafavi mksafavi mentioned this pull request Dec 22, 2024
13 tasks
@mksafavi
Copy link
Contributor Author

There's a name conflict with another package. I renamed this to conjure-tor. If you have any suggestions for the name let me know.

Copy link
Member

@PerchunPak PerchunPak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

conjure-tor is fine

Comment on lines 7 to 8
name = "conjure-tor";
version = "0-unstable-2024-12-22";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
name = "conjure-tor";
version = "0-unstable-2024-12-22";
pname = "conjure-tor";
version = "0-unstable-2024-11-11";

The date in unstable releases should be the date of commit, not today


meta = {
homepage = "https://gitlab.torproject.org/tpo/anti-censorship/pluggable-transports/conjure";
description = "Conjure is a refraction networking system that routes traffic to endpoints in an ISP's unused IP address space";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
description = "Conjure is a refraction networking system that routes traffic to endpoints in an ISP's unused IP address space";
description = "Refraction networking system that routes traffic to endpoints in an ISP's unused IP address space";

@mksafavi mksafavi force-pushed the pkg/conjure branch 2 times, most recently from 90439a0 to 0340d0b Compare December 22, 2024 18:07
@mksafavi mksafavi changed the title conjure-tor: init at 0-unstable-2024-12-22 conjure-tor: init at 0-unstable-2024-11-11 Dec 22, 2024
Copy link
Member

@PerchunPak PerchunPak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exits with retrying conjure registration, station is under high load, assuming works

@PerchunPak
Copy link
Member

How about updateScript? (it is applied automatically to all python packages, but not go)

@mksafavi
Copy link
Contributor Author

How about updateScript? (it is applied automatically to all python packages, but not go)

What should I set it to? Is passthru.updateScript = nix-update-script { }; enough?

@PerchunPak
Copy link
Member

How about updateScript? (it is applied automatically to all python packages, but not go)

What should I set it to? Is passthru.updateScript = nix-update-script { }; enough?

Yes

@PerchunPak PerchunPak added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Dec 22, 2024
@PerchunPak
Copy link
Member

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 367417


x86_64-linux

✅ 1 package built:
  • conjure-tor

aarch64-linux

✅ 1 package built:
  • conjure-tor

x86_64-darwin

✅ 1 package built:
  • conjure-tor

aarch64-darwin

✅ 1 package built:
  • conjure-tor

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1 10.rebuild-linux: 1 labels Dec 23, 2024
@wegank wegank removed the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Dec 23, 2024
@mksafavi
Copy link
Contributor Author

Hi @wegank
Is there anything needed for this PR?

@PerchunPak PerchunPak added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Dec 23, 2024
@mksafavi mksafavi requested a review from Aleksanaa December 25, 2024 19:30
@PerchunPak
Copy link
Member

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 367417


x86_64-linux

✅ 1 package built:
  • conjure-tor

aarch64-linux

✅ 1 package built:
  • conjure-tor

x86_64-darwin

✅ 1 package built:
  • conjure-tor

aarch64-darwin

✅ 1 package built:
  • conjure-tor

@mksafavi mksafavi requested a review from getchoo January 8, 2025 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants