Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

octavePackages.ocl: 1.2.2 -> 1.2.3 #367444

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

r-ryantm
Copy link
Contributor

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.

meta.description for octavePackages.ocl is: Use OpenCL for parallelization

meta.homepage for octavePackages.ocl is: https://octave.sourceforge.io/ocl/index.html

Updates performed
  • Ran passthru.UpdateScript
To inspect upstream changes
Impact

Checks done


  • built on NixOS
  • The tests defined in passthru.tests, if any, passed
  • found 1.2.3 with grep in /nix/store/3vfy8x1znrl34wrbdpgql2m392yasc4r-octave-9.3.0-ocl-1.2.3
  • found 1.2.3 in filename of file in /nix/store/3vfy8x1znrl34wrbdpgql2m392yasc4r-octave-9.3.0-ocl-1.2.3

Rebuild report (if merged into master) (click to expand)
2 total rebuild path(s)

2 package rebuild(s)

First fifty rebuilds by attrpath

octavePackages.ocl
Instructions to test this update (click to expand)

Either download from the cache:

nix-store -r /nix/store/3vfy8x1znrl34wrbdpgql2m392yasc4r-octave-9.3.0-ocl-1.2.3 \
  --option binary-caches 'https://cache.nixos.org/ https://nixpkgs-update-cache.nix-community.org/' \
  --option trusted-public-keys '
  nixpkgs-update-cache.nix-community.org-1:U8d6wiQecHUPJFSqHN9GSSmNkmdiFW7GW7WNAnHW0SM=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The nixpkgs-update cache is only trusted for this store-path realization.)
For the cached download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.

Or, build yourself:

nix-build -A octavePackages.ocl https://github.com/r-ryantm/nixpkgs/archive/3dfcbb6343e2357aec0283e16282ed07abc59daa.tar.gz

Or:

nix build github:r-ryantm/nixpkgs/3dfcbb6343e2357aec0283e16282ed07abc59daa#octavePackages.ocl

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/3vfy8x1znrl34wrbdpgql2m392yasc4r-octave-9.3.0-ocl-1.2.3
ls -la /nix/store/3vfy8x1znrl34wrbdpgql2m392yasc4r-octave-9.3.0-ocl-1.2.3/bin


Pre-merge build results

We have automatically built all packages that will get rebuilt due to
this change.

This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review


x86_64-linux

✅ 1 package built:
  • octavePackages.ocl

Maintainer pings

cc @KarlJoad for testing.

Tip

As a maintainer, if your package is located under pkgs/by-name/*, you can comment @NixOS/nixpkgs-merge-bot merge to automatically merge this update using the nixpkgs-merge-bot.


Add a 👍 reaction to pull requests you find important.

Copy link
Contributor

@KarlJoad KarlJoad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All built-in tests fail. v1.2.2 is the same.

@ofborg ofborg bot requested a review from KarlJoad December 23, 2024 09:40
@wegank wegank marked this pull request as draft January 1, 2025 18:15
@KarlJoad
Copy link
Contributor

KarlJoad commented Jan 6, 2025

Tests fail because ocl is a wrapper around OpenCL for Octave. I forgot to include OpenCL as a library. So obviously everything is broken. Slowly working on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants