Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mautrix-signal: 0.7.3 -> 0.7.4 #367446

Merged
merged 2 commits into from
Dec 29, 2024
Merged

mautrix-signal: 0.7.3 -> 0.7.4 #367446

merged 2 commits into from
Dec 29, 2024

Conversation

Ma27
Copy link
Member

@Ma27 Ma27 commented Dec 22, 2024

cc @niklaskorz

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@niklaskorz
Copy link
Contributor

Getting:

Dec 22 21:42:53 korz-tech mautrix-signal[440803]: runtime/cgo: pthread_create failed: Permission denied
Dec 22 21:42:53 korz-tech mautrix-signal[440803]: SIGABRT: abort

I think the mautrix-signal module's systemd settings need adjustments.

Another note: libsignal-ffi should probably move to useFetchCargoVendor instead of updating the Cargo.lock. But to not cause conflicts with the backport for 24.05 it might be best to just wait until the next update for that change (useFetchCargoVendor has been backported to 24.11 but not 24.05 I think?).

@Ma27
Copy link
Member Author

Ma27 commented Dec 22, 2024

I think the mautrix-signal module's systemd settings need adjustments.

Right, I use my own module, hence I didn't encounter that (sent messages successfully with that update already).
Sometimes systemd writes into the journal (and dmesg) what triggered this, so you may wantt o check.

@niklaskorz
Copy link
Contributor

niklaskorz commented Dec 22, 2024

I forgot the module change in #358785 and was running on the unchanged 24.11 module. Added backport labels to #358785 so the update does not break 24.05 and 24.11 modules.

@ofborg ofborg bot requested a review from niklaskorz December 23, 2024 09:00
@wegank wegank added 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package labels Dec 23, 2024
@niklaskorz niklaskorz added the backport release-24.11 Backport PR automatically label Dec 25, 2024
@Ma27 Ma27 merged commit 5a9fe1f into NixOS:master Dec 29, 2024
44 of 45 checks passed
@Ma27 Ma27 deleted the bump-mautrix-signal branch December 29, 2024 15:57
@nix-backports
Copy link

nix-backports bot commented Dec 29, 2024

Backport failed for release-24.05, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin release-24.05
git worktree add -d .worktree/backport-367446-to-release-24.05 origin/release-24.05
cd .worktree/backport-367446-to-release-24.05
git switch --create backport-367446-to-release-24.05
git cherry-pick -x ad10a09e5a782212423e929986d533d7a0a5c707 70952477bf555847126f3e0bfe7027eaaf19f813

@nix-backports
Copy link

nix-backports bot commented Dec 29, 2024

Successfully created backport PR for release-24.11:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package backport release-24.11 Backport PR automatically
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants