Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python312Packages.webauthn 2.2.0 -> 2.4.0 #367457

Closed
wants to merge 4 commits into from
Closed

python312Packages.webauthn 2.2.0 -> 2.4.0 #367457

wants to merge 4 commits into from

Conversation

aucub
Copy link
Contributor

@aucub aucub commented Dec 22, 2024

Fixes #367397

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@aucub aucub changed the base branch from master to staging December 22, 2024 22:10
@aucub aucub marked this pull request as draft December 22, 2024 22:11
@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 6.topic: games 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 6.topic: llvm/clang Issues related to llvmPackages, clangStdenv and related labels Dec 22, 2024
@aucub aucub changed the base branch from staging to staging-next December 22, 2024 22:17
@aucub aucub marked this pull request as ready for review December 22, 2024 22:17
@github-actions github-actions bot added 10.rebuild-darwin: 2501-5000 and removed 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 6.topic: games 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 6.topic: llvm/clang Issues related to llvmPackages, clangStdenv and related 10.rebuild-darwin: 5001+ labels Dec 22, 2024
@aucub aucub changed the title python3Packages.webauthn 2.2.0 → 2.4.0 python3Packages.webauthn 2.2.0 -> 2.4.0 Dec 23, 2024
@aucub aucub changed the title python3Packages.webauthn 2.2.0 -> 2.4.0 python312Packages.webauthn 2.2.0 -> 2.4.0 Dec 23, 2024
@mweinelt
Copy link
Member

Too big for staging-next at this point. Target staging instead.

@mweinelt mweinelt marked this pull request as draft December 23, 2024 01:35
@aucub aucub changed the base branch from staging-next to staging December 23, 2024 01:51
@aucub aucub marked this pull request as ready for review December 23, 2024 01:51
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/5004

@mweinelt
Copy link
Member

Missing changelogs in the commit messages, check https://github.com/NixOS/nixpkgs/blob/master/pkgs/README.md#commit-conventions.

Also breaks pretix.

@aucub aucub closed this Dec 26, 2024
@aucub aucub deleted the webauthn branch December 26, 2024 02:24
@mweinelt
Copy link
Member

Replaced by #368359

@cole-h cole-h removed the ofborg-internal-error Ofborg encountered an error label Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 501+ 10.rebuild-darwin: 1001-2500 10.rebuild-linux: 501+ 10.rebuild-linux: 2501-5000
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update request: python3Packages.webauthn 2.2.0 → 2.4.0
4 participants
@aucub @mweinelt @nixos-discourse @cole-h