restate: init at 1.1.6 #367466
restate: init at 1.1.6 #367466
Conversation
github-actions
bot
added
the
8.has: maintainer-list (update)
NixOSInfra
added
the
12. first-time contribution
pkgs/by-name/re/restate/package.nix
Outdated
| restate, | ||
| }: | ||
| let | ||
| # Have to link against this fork until this PR is merged |
There was a problem hiding this comment.
You can put the diff the PR represents into the folder with the package.nix and apply it to the source, then pull from the original repo
There was a problem hiding this comment.
On testing I have realized that it needs more than a single PR I have mentioned to build. A diff against their fork generates 12 patches, so I have removed the nixpkgs input altogether, now rustPlatform.buildRustPackage builds it instead. I think, that a benefit of this approach, is that rocksdb is linked statically then.
pkgs/by-name/re/restate/package.nix
Outdated
| src = fetchFromGitHub { | ||
| owner = "restatedev"; | ||
| repo = "restate"; | ||
| rev = "v${version}"; |
ofborg
bot
added
8.has: package (new)
|
It looks good to me, but I don't have commit access, and don't maintain a similar package, so it doesn't make sense for me to leave an approving review. My suggestion to get it merged would be to find someone who has merged a PR comparable to this into nixpkgs recently, and ping them for a review. Good luck! |
|
@GaetanLepage |
pkgs/by-name/re/restate/package.nix
Outdated
| cargoHash = "sha256-z7VAKU4bi6pX2z4jCKWDfQt8FFLN7ugnW2LOy6IHz/w="; | ||
|
|
||
| env = { | ||
| PROTOC = "${protobuf}/bin/protoc"; |
There was a problem hiding this comment.
| PROTOC = "${protobuf}/bin/protoc"; | |
| PROTOC = lib.getExe protobuf; |
pkgs/by-name/re/restate/package.nix
Outdated
| auditable = false; | ||
|
|
||
| passthru = { |
There was a problem hiding this comment.
| auditable = false; | |
| passthru = { | |
| auditable = false; | |
| nativeInstallCheckInputs = [ | |
| versionCheckHook | |
| ]; | |
| versionCheckProgramArg = [ "--version" ]; | |
| doInstallCheck = true; | |
| passthru = { |
Add this one too as it will run at build time.
pkgs/by-name/re/restate/package.nix
Outdated
| homepage = "https://restate.dev"; | ||
| mainProgram = "restate"; |
There was a problem hiding this comment.
| homepage = "https://restate.dev"; | |
| mainProgram = "restate"; | |
| homepage = "https://restate.dev"; | |
| changelog = "https://github.com/restatedev/restate/releases/tag/v${version}"; | |
| mainProgram = "restate"; |
pkgs/by-name/re/restate/package.nix
Outdated
| PROTOC_INCLUDE = "${protobuf}/include"; | ||
|
|
||
| VERGEN_GIT_COMMIT_DATE = "2024-12-23"; | ||
| VERGEN_GIT_SHA = src.tag; |
There was a problem hiding this comment.
| VERGEN_GIT_SHA = src.tag; | |
| VERGEN_GIT_SHA = "v${version}"; |
It's better not to rely on src fields as they might not be available when overriding src.
There was a problem hiding this comment.
Makes sense for ergonomics. Force pushed a fix.
|
@ofborg build restate |
pkgs/by-name/re/restate/package.nix
Outdated
| auditable = false; | ||
|
|
||
| nativeInstallCheckInputs = [ |
There was a problem hiding this comment.
| auditable = false; | |
| nativeInstallCheckInputs = [ | |
| auditable = false; | |
| __darwinAllowLocalNetworking = true; | |
| nativeInstallCheckInputs = [ |
|
|
myypo
force-pushed
the
init-restate
branch
2 times, most recently
from
5ea647c to
5bce0ee
Compare
|
In the other order ;) |
Thanks, changed the order. Got a bit confused by the manual on it. |
|
Restate is a tool for developing durable workflows
Closes #325360
Have tried running several official examples and it seems to be working fine.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.