Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

soarca: init at 1.1.0-beta-1-unstable-2024-12-19 #367485

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

soarca: init at 1.1.0-beta-1-unstable-2024-12-19 #367485

wants to merge 1 commit into from

Conversation

13621
Copy link
Contributor

@13621 13621 commented Dec 22, 2024 •
edited
Loading

Added SOARCA, an open source security orchestrator for CACAO playbooks written in Go. Includes package and NixOS module.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: documentation This PR adds or changes documentation 8.has: changelog 8.has: module (update) This PR changes an existing module in `nixos/` labels Dec 22, 2024
@13621
Copy link
Contributor Author

13621 commented Dec 22, 2024

@ofborg test soarca

@13621
Copy link
Contributor Author

13621 commented Dec 22, 2024

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 367485

x86_64-linux

⏩ 1 package blacklisted:
  • nixos-install-tools
✅ 1 package built:
  • soarca

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1 labels Dec 23, 2024
@13621 13621 force-pushed the soarca branch 3 times, most recently from 8c83cb9 to 60e5033 Compare December 23, 2024 16:10
@13621 13621 changed the title soarca: init at unstable-2024-12-19 soarca: init at 1.1.0-beta-1-unstable-2024-12-19 Dec 23, 2024
lucasew
lucasew suggested changes Dec 23, 2024
View reviewed changes
pkgs/by-name/so/soarca/package.nix Outdated Show resolved Hide resolved
lucasew
lucasew suggested changes Dec 23, 2024
View reviewed changes
pkgs/by-name/so/soarca/package.nix

buildGoModule {
pname = "soarca";
version = "1.1.0-beta-1-unstable-2024-12-19";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This version is based on a GitHub tag/release, so no need of unstable.

Also, you can use this version in rev.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried to package the latest available version (with some bugfixes), which strictly speaking isn't the tag 1.1.0-beta-1, but a newer, untagged version. I followed the versioning guide as closely as possible, but let me know and I'll change it. This is my second ever contribution to Nixpkgs :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it

@13621 13621 requested a review from lucasew December 23, 2024 20:41
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review-december/1711/25

@13621
Copy link
Contributor Author

13621 commented Dec 25, 2024

Hardened the systemd unit for good measure.

@13621
Copy link
Contributor Author

13621 commented Dec 25, 2024

@ofborg test soarca

@13621
Copy link
Contributor Author

13621 commented Jan 10, 2025

@getchoo hi, you helped me with my first PR, can you take a look at this if you have time? :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucasew lucasew Awaiting requested review from lucasew

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: changelog 8.has: documentation This PR adds or changes documentation 8.has: module (update) This PR changes an existing module in `nixos/` 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@13621 @nixos-discourse @lucasew