-
-
Notifications
You must be signed in to change notification settings - Fork 14.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update RoCM substitutions for tinygrad #367501
Conversation
AMD replaced their hardcoded `/opt/rocm/lib` paths with `ROCM_PATH, '/opt/rocm/'` variables, the old `substituteInPlace` no longer matched the strings and did the substitutions resulting in the libraries not being found at runtime.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks !
There might be a patch needed for the At least I have this patched in tinygrad-nix. But otherwise, LGTM. |
@wozeparrot's fixes for compiler_hip.py
Thanks @wozeparrot, I added patches for compiler_hip.py too... was able to get through testing (ran over SSH maybe that's why). cd into the nix/store/tinygrad directory and ran some checks
|
|
AMD replaced their hardcoded
/opt/rocm/lib
paths withROCM_PATH, '/opt/rocm/'
variables, the oldsubstituteInPlace
no longer matched the strings and did the substitutions resulting in the libraries not being found at runtime.When I changed this I had to disable running tests (not part of this PR) because the tests crash the machine I'm using... (yay AMD!) ; for that have to do
doCheck = !rocmSupport;
.FYI @GaetanLepage
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.