Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

haskellPackages.unbound-generics: Unmark broken #367503

Merged

Conversation

ozkutuk
Copy link
Contributor

@ozkutuk ozkutuk commented Dec 23, 2024

I don't know why this was marked broken in the first place but seems to be working alright now.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot added the 8.has: package (new) This PR adds a new package label Dec 23, 2024
@sternenseemann sternenseemann merged commit d43d9d1 into NixOS:haskell-updates Dec 23, 2024
41 of 42 checks passed
@sternenseemann
Copy link
Member

unbound-generics-unify is failing: https://hydra.nixos.org/build/282938583

@ozkutuk
Copy link
Contributor Author

ozkutuk commented Dec 24, 2024

unbound-generics-unify is failing: https://hydra.nixos.org/build/282938583

Is that a problem? I don't know too much about nixpkgs-haskell maintenance, but the way I understand it, running regenerate-transitive-broken-packages script removed unbound-generics-unify from transitive-broken.yaml since it was broken because of unbound-generics, but now it is broken for a different reason.

What I did was roughly:

  1. remove unbound-generics from broken.yaml
  2. run regenerate-hackage-packages.sh
  3. run regenerate-transitive-broken-packages.sh
  4. edit the diffs a bit to remove unrelated changes

@sternenseemann
Copy link
Member

regenerate-transitive-broken-packages.sh is unnecessary, regenerate-hackage-packages.sh (without --fast) runs it already.

My comment was purely informational, I assume you are somehow interested in this package and possibly related ones.

@ozkutuk
Copy link
Contributor Author

ozkutuk commented Dec 25, 2024

regenerate-transitive-broken-packages.sh is unnecessary, regenerate-hackage-packages.sh (without --fast) runs it already.

Good to know.

My comment was purely informational, I assume you are somehow interested in this package and possibly related ones.

unbound-generics was enough for my usecase, thanks for the heads-up though!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants