Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Some Static IDs #367563

Merged
merged 3 commits into from
Dec 24, 2024
Merged

Remove Some Static IDs #367563

merged 3 commits into from
Dec 24, 2024

Conversation

ElvishJerricco
Copy link
Contributor

A couple of changes to ids.nix, against RFC 52, have slipped through the cracks.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 6.topic: hardware 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Dec 23, 2024
r-vdp
r-vdp approved these changes Dec 23, 2024
View reviewed changes
Copy link
Contributor

@r-vdp r-vdp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@r-vdp
Copy link
Contributor

r-vdp commented Dec 23, 2024

@ElvishJerricco should we maybe also add a couple of people to CODEOWNERS for this file? it's still possible to miss the comment on the top if your editor just drops you somewhere in the file (because you used a search function or such) and right now no-one would be notified if someone allocates new IDs.

I don't mind volunteering to get pinged for changes to this file, now that I'm aware :)

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Dec 23, 2024
@alyssais alyssais removed their request for review December 23, 2024 20:41
@github-actions github-actions bot added the 6.topic: continuous integration Affects continuous integration (CI) in Nixpkgs, including Ofborg and GitHub Actions label Dec 23, 2024
@ElvishJerricco
Copy link
Contributor Author

@r-vdp Done :) Look good to you?

@r-vdp r-vdp merged commit 4af8ef3 into NixOS:master Dec 24, 2024
26 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@r-vdp r-vdp r-vdp approved these changes

@paveloom paveloom Awaiting requested review from paveloom

@infinisil infinisil Awaiting requested review from infinisil

@philiptaron philiptaron Awaiting requested review from philiptaron

Assignees
No one assigned
Labels
6.topic: continuous integration Affects continuous integration (CI) in Nixpkgs, including Ofborg and GitHub Actions 6.topic: hardware 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ElvishJerricco @r-vdp @wegank