Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cargo-3ds: init at 0.1.3 #367583

Merged
merged 2 commits into from
Jan 3, 2025
Merged

cargo-3ds: init at 0.1.3 #367583

merged 2 commits into from
Jan 3, 2025

Conversation

l1npengtul
Copy link
Contributor

Adds cargo-3ds cargo package to nixpkgs. Init at v0.1.3

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` label Dec 23, 2024
@NixOSInfra NixOSInfra added the 12. first-time contribution This PR is the author's first one; please be gentle! label Dec 23, 2024
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1 10.rebuild-linux: 1 labels Dec 23, 2024
pkgs/by-name/ca/cargo-3ds/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/ca/cargo-3ds/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/ca/cargo-3ds/package.nix Outdated Show resolved Hide resolved
@Adda0
Copy link
Contributor

Adda0 commented Dec 25, 2024

When all the changes are done, I would recommend squashing all the cargo-3ds commits into a single commit, so that the commit only contains the maintainers commit and a single init package commit.

@l1npengtul
Copy link
Contributor Author

When all the changes are done, I would recommend squashing all the cargo-3ds commits into a single commit, so that the commit only contains the maintainers commit and a single init package commit.

Noted, WILCO.

Copy link
Contributor

@Adda0 Adda0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR looks good to me. Thanks for your contribution.

@l1npengtul
Copy link
Contributor Author

The PR looks good to me. Thanks for your contribution.

Thank you!

@wegank wegank added the 12.approvals: 2 This PR was reviewed and approved by two reputable people label Dec 29, 2024
@misuzu misuzu merged commit 3cbcf3e into NixOS:master Jan 3, 2025
44 of 45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 2 This PR was reviewed and approved by two reputable people 12. first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants