Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ente-auth: 4.1.6 -> 4.2.1 #367587

Merged
merged 1 commit into from
Dec 27, 2024
Merged

ente-auth: 4.1.6 -> 4.2.1 #367587

merged 1 commit into from
Dec 27, 2024
+25 −15

Conversation

niklaskorz
Copy link
Contributor

@niklaskorz niklaskorz commented Dec 23, 2024 •
edited
Loading

Changelogs:

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Dec 23, 2024
@ofborg ofborg bot requested review from schnow265, zi3m5f and gepbird December 23, 2024 22:02
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-linux: 1 labels Dec 23, 2024
@donovanglover
Copy link
Member

Diff LGTM can someone test the binary?

gepbird
gepbird approved these changes Dec 27, 2024
View reviewed changes
Copy link
Contributor

@gepbird gepbird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the binary on x86_64-linux, thanks!

@niklaskorz
Copy link
Contributor Author

4.2.1 came out today, will update in a sec

@niklaskorz niklaskorz changed the title ente-auth: 4.1.6 -> 4.2.0 ente-auth: 4.1.6 -> 4.2.1 Dec 27, 2024
@niklaskorz niklaskorz added the backport release-24.11 Backport PR automatically label Dec 27, 2024
@ofborg ofborg bot requested review from schnow265 and gepbird December 27, 2024 11:25
gepbird
gepbird approved these changes Dec 27, 2024
View reviewed changes
Copy link
Contributor

@gepbird gepbird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Binary works

@donovanglover
Copy link
Member

Thanks everyone!

@donovanglover donovanglover merged commit 7929bdc into NixOS:master Dec 27, 2024
66 of 67 checks passed
@nix-backports
Copy link

nix-backports bot commented Dec 27, 2024

Successfully created backport PR for release-24.11:

@nix-backports nix-backports bot mentioned this pull request Dec 27, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gepbird gepbird gepbird approved these changes

@zi3m5f zi3m5f Awaiting requested review from zi3m5f

@schnow265 schnow265 Awaiting requested review from schnow265

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes backport release-24.11 Backport PR automatically
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@niklaskorz @donovanglover @gepbird @schnow265