-
-
Notifications
You must be signed in to change notification settings - Fork 14.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
qemu: use apple-sdk_13; fix build #367606
Conversation
qemu 9.2.0 uses hv_vm_config_get_default_ipa_size which showed up in macOS 13
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I tested it builds on aarch64-darwin now.
Ack |
if stdenv.hostPlatform.isDarwin then | ||
overrideSDK stdenv { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is another overrideSDK
in qemu
that can probably be removed?
nixpkgs/pkgs/applications/virtualization/qemu/default.nix
Lines 60 to 68 in 7dd2a13
buildPlatformStdenv = | |
if stdenv.buildPlatform.isDarwin then | |
overrideSDK buildPackages.stdenv { | |
# Keep these values in sync with `all-packages.nix`. | |
darwinSdkVersion = "12.3"; | |
darwinMinVersion = "12.0"; | |
} | |
else | |
buildPackages.stdenv; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed in #367764
qemu 9.2.0 uses hv_vm_config_get_default_ipa_size which showed up in macOS 13
https://hydra.nixos.org/build/282523939
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.