Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python312Packages.taichi: init at 1.7.2 #367617

Closed
wants to merge 1 commit into from
Closed

Conversation

arunoruto
Copy link
Contributor

@arunoruto arunoruto commented Dec 23, 2024

Packaging taichi from PyPI with CUDA, Vulkan, and OpenGL support. I used jaxlib-bin as an inspiration on how to package taichi from PyPI, and in the future the default library should point to a build compiled from source.

Problems:

  1. When running ti example and selecting, for example, 16, i.e., fractal3d_ggui, it crashes with the following response:
Running example fractal3d_ggui ...
[Taichi] Starting on arch=vulkan
RHI Error: (2) vkAcquireNextImageKHR failed
python3.12: /home/dev/taichi/taichi/rhi/vulkan/vulkan_device.cpp:2808: virtual taichi::lang::StreamSemaphore taichi::lang::vulkan::VulkanSurface::acquire_next_image(): Assertion `false && "Error without return code"' failed.
fish: Job 1, 'ti example' terminated by signal SIGABRT (Abort)

Continuation of #233365
Closes #143181

TODO:

  • Test on Nvidia machine
  • Include hashes for 3.11 and x86/arm darwin systems
  • Fix RHI Error: (2) vkAcquireNextImageKHR failed if vulkan is set as arch
  • Find out how to enable amdgpu support using ROCm, i.e., which library needs to be added It seems like the package needs to be built using llvm from ROCm according to this issue -> not meant for this release

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@arunoruto
Copy link
Contributor Author

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 367617


x86_64-linux

✅ 2 packages built:
  • python312Packages.taichi
  • python312Packages.taichi.dist

@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Dec 23, 2024
@arunoruto arunoruto force-pushed the taichi branch 2 times, most recently from 019e7b4 to bc90607 Compare December 23, 2024 11:58
@arunoruto arunoruto added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin and removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin labels Dec 23, 2024
@arunoruto arunoruto changed the title python312Packages.taichi: init at 1.7.2 python3Packages.taichi: init at 1.7.2 Dec 23, 2024
@github-actions github-actions bot added 10.rebuild-darwin: 1-10 and removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin labels Dec 23, 2024
@arunoruto arunoruto changed the title python3Packages.taichi: init at 1.7.2 python312Packages.taichi: init at 1.7.2 Dec 23, 2024
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1 10.rebuild-linux: 1 labels Dec 24, 2024
@arunoruto arunoruto marked this pull request as ready for review January 3, 2025 00:27
@nix-owners nix-owners bot requested a review from natsukium January 3, 2025 00:29
@arunoruto
Copy link
Contributor Author

I just managed to build taichi from source, so I am closing this PR in favour of a from source build!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

REQUEST: Add the Taichi Python package
1 participant