Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fvm: init at 3.2.1 #367700

Closed
wants to merge 0 commits into from
Closed

fvm: init at 3.2.1 #367700

wants to merge 0 commits into from

Conversation

MH0386
Copy link

@MH0386 MH0386 commented Dec 23, 2024

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@NixOSInfra NixOSInfra added the 12. first-time contribution This PR is the author's first one; please be gentle! label Dec 23, 2024
lucasew
lucasew suggested changes Dec 23, 2024
View reviewed changes
Copy link
Contributor

@lucasew lucasew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also please rename the PR and the package commit to fvm: init at 3.2.1. This comes from CONTRIBUTING.md.

pkgs/by-name/fv/fvm/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/fv/fvm/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/fv/fvm/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/fv/fvm/package.nix Outdated Show resolved Hide resolved
@MH0386 MH0386 changed the title Add fvm fvm: init at 3.2.1 Dec 23, 2024
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1 10.rebuild-linux: 1 labels Dec 24, 2024
@MH0386
Copy link
Author

MH0386 commented Dec 24, 2024

I curious about ofborg. Why it takes long time?
@lucasew

@lucasew
Copy link
Contributor

lucasew commented Dec 24, 2024

I curious about ofborg. Why it takes long time? @lucasew

A new commit restarts the process. And stuff is processed in a queue where there is other PRs.

@MH0386 MH0386 requested a review from lucasew December 25, 2024 12:03
@MH0386
Copy link
Author

MH0386 commented Dec 25, 2024

What next?

@lucasew
Copy link
Contributor

lucasew commented Dec 25, 2024

Join (squash commits).

One to add your name in the maintainers list and another to add your package.

@github-actions github-actions bot added 6.topic: python 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: documentation This PR adds or changes documentation 8.has: changelog 8.has: module (update) This PR changes an existing module in `nixos/` 6.topic: ruby 6.topic: vim 6.topic: erlang 6.topic: ocaml labels Dec 26, 2024
@github-actions github-actions bot added 6.topic: nodejs 6.topic: hardware 6.topic: coq "A formal proof management system" 6.topic: vscode 6.topic: jupyter Interactive computing tooling: kernels, notebook, jupyterlab 6.topic: games 6.topic: deepin Desktop environment and its components 6.topic: llvm/clang Issues related to llvmPackages, clangStdenv and related 6.topic: continuous integration Affects continuous integration (CI) in Nixpkgs, including Ofborg and GitHub Actions labels Dec 26, 2024
@K900
Copy link
Contributor

K900 commented Dec 26, 2024

What the hell is happening here. Please clean up your commit history and don't touch unrelated files.

@MH0386 MH0386 closed this Dec 26, 2024
@MH0386 MH0386 deleted the add-fvm branch December 26, 2024 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucasew lucasew Awaiting requested review from lucasew

@alyssais alyssais Awaiting requested review from alyssais

@dtzWill dtzWill Awaiting requested review from dtzWill

@Ericson2314 Ericson2314 Awaiting requested review from Ericson2314

@figsoda figsoda Awaiting requested review from figsoda

@GaetanLepage GaetanLepage Awaiting requested review from GaetanLepage

@infinisil infinisil Awaiting requested review from infinisil

@K900 K900 Awaiting requested review from K900

@khaneliman khaneliman Awaiting requested review from khaneliman

@lovek323 lovek323 Awaiting requested review from lovek323

@Ma27 Ma27 Awaiting requested review from Ma27

@manveru manveru Awaiting requested review from manveru

@mattpolzin mattpolzin Awaiting requested review from mattpolzin

@mrcjkb mrcjkb Awaiting requested review from mrcjkb

@natsukium natsukium Awaiting requested review from natsukium

@NickCao NickCao Awaiting requested review from NickCao

Assignees
No one assigned
Labels
6.topic: continuous integration Affects continuous integration (CI) in Nixpkgs, including Ofborg and GitHub Actions 6.topic: coq "A formal proof management system" 6.topic: deepin Desktop environment and its components 6.topic: erlang 6.topic: fetch 6.topic: games 6.topic: hardware 6.topic: jupyter Interactive computing tooling: kernels, notebook, jupyterlab 6.topic: llvm/clang Issues related to llvmPackages, clangStdenv and related 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: nodejs 6.topic: ocaml 6.topic: python 6.topic: ruby 6.topic: vim 6.topic: vscode 8.has: changelog 8.has: documentation This PR adds or changes documentation 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 8.has: module (update) This PR changes an existing module in `nixos/` 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12. first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MH0386 @lucasew @K900 @NixOSInfra