Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ladybird: 0-unstable-2024-11-21 -> 0-unstable-2024-12-23 #367747

Merged
merged 1 commit into from
Dec 26, 2024

Conversation

fgaz
Copy link
Member

@fgaz fgaz commented Dec 23, 2024

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ddogfoodd
Copy link

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 367747


x86_64-linux

✅ 1 package built:
  • ladybird

Copy link

@ddogfoodd ddogfoodd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

builds but crashes for me shortly after opening on x86_64-linux

@fgaz
Copy link
Member Author

fgaz commented Dec 23, 2024

builds but crashes for me shortly after opening on x86_64-linux

Are you on NixOS? Did you enable the ladybird option?

@ddogfoodd
Copy link

Are you on NixOS? Did you enable the ladybird option?

Yes and I didn't, so that might have been the problem

@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1 10.rebuild-linux: 1 labels Dec 24, 2024
@qbit
Copy link
Contributor

qbit commented Dec 26, 2024

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 367747


x86_64-linux

✅ 1 package built:
  • ladybird

@qbit
Copy link
Contributor

qbit commented Dec 26, 2024

Runs as expected (with it enabled \o/)!

@fgaz fgaz merged commit 93a0014 into NixOS:master Dec 26, 2024
75 of 76 checks passed
@fgaz fgaz deleted the ladybird/2024-12-23 branch December 26, 2024 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants