Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

makejinja: 2.6.2 -> 2.7.2 #367762

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

mirkolenz
Copy link
Member

  • Update makejinja to v2.7.2
  • Switch build-system to setuptools (makejinja switched from poetry to uv starting with v2.7.0)
  • Use tag instead of rev for fetching the sources

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@lucasewd
Copy link

@lucasewd
Copy link

nixpkgs-reviewd workflow finished

Status and logs: https://github.com/nixosbrasil/nixpkgs-reviewd/actions/runs/12474044145

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 367762


x86_64-darwin

✅ 2 packages built:
  • makejinja
  • makejinja.dist

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 367762


aarch64-darwin

✅ 2 packages built:
  • makejinja
  • makejinja.dist

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 367762


x86_64-linux

✅ 2 packages built:
  • makejinja
  • makejinja.dist

@ofborg ofborg bot requested a review from TomaSajt December 24, 2024 13:34
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1 10.rebuild-linux: 1 labels Dec 24, 2024
Copy link
Contributor

@TomaSajt TomaSajt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

A small improvement would be to add a meta.changelog field to the derivation

@mirkolenz
Copy link
Member Author

Yeah, makes sense. Should I use the GitHub releases page as the changelog?

@TomaSajt
Copy link
Contributor

Yeah, makes sense. Should I use the GitHub releases page as the changelog?

I think the usual was it's done is that you use the changelog file if possible and fall back to the release page if that's not present.

In this case, since there's a changelog file, you'd use this:
https://github.com/mirkolenz/makejinja/blob/${src.rev}/CHANGELOG.md

@wegank wegank added 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package 12.approvals: 1 This PR was reviewed and approved by one reputable person labels Dec 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants