-
-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
makejinja: 2.6.2 -> 2.7.2 #367762
base: master
Are you sure you want to change the base?
makejinja: 2.6.2 -> 2.7.2 #367762
Conversation
nixpkgs-reviewd workflow startedStatus and logs: https://github.com/nixosbrasil/nixpkgs-reviewd/actions/runs/12474044145 |
nixpkgs-reviewd workflow finishedStatus and logs: https://github.com/nixosbrasil/nixpkgs-reviewd/actions/runs/12474044145
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
A small improvement would be to add a meta.changelog
field to the derivation
Yeah, makes sense. Should I use the GitHub releases page as the changelog? |
I think the usual was it's done is that you use the changelog file if possible and fall back to the release page if that's not present. In this case, since there's a changelog file, you'd use this: |
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.