-
-
Notifications
You must be signed in to change notification settings - Fork 14.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
monero-cli: fix build issue with GCC14 #367932
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
10.rebuild-darwin: 0
This PR does not cause any packages to rebuild on Darwin
10.rebuild-linux: 1-10
labels
Dec 24, 2024
gador
changed the title
monero-cli: 0.18.3.4 -> 0-unstable-2024-12-23
monero-cli,monero-gui: 0.18.3.4 -> 0-unstable-2024-12-23
Dec 24, 2024
gador
force-pushed
the
monero-cli-gcc14
branch
from
December 24, 2024 18:05
fb6bcf1
to
44ebecc
Compare
ofborg
bot
added
10.rebuild-darwin: 1-10
and removed
10.rebuild-darwin: 0
This PR does not cause any packages to rebuild on Darwin
labels
Dec 25, 2024
gador
force-pushed
the
monero-cli-gcc14
branch
from
December 25, 2024 09:31
44ebecc
to
de606e9
Compare
gador
changed the title
monero-cli,monero-gui: 0.18.3.4 -> 0-unstable-2024-12-23
monero-cl: fix build issue with GCC14
Dec 25, 2024
gador
force-pushed
the
monero-cli-gcc14
branch
from
December 25, 2024 09:31
de606e9
to
ef3dd1c
Compare
gador
changed the title
monero-cl: fix build issue with GCC14
monero-cli: fix build issue with GCC14
Dec 25, 2024
|
|
rnhmjoj
reviewed
Dec 26, 2024
gador
force-pushed
the
monero-cli-gcc14
branch
from
December 26, 2024 06:25
ef3dd1c
to
b6bbaed
Compare
fixes NixOS#367857 Signed-off-by: Florian Brandes <[email protected]>
gador
force-pushed
the
monero-cli-gcc14
branch
from
December 26, 2024 06:27
b6bbaed
to
45cd7cf
Compare
rnhmjoj
approved these changes
Dec 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did the usual test: connect monero-gui to a remote node. Looks good.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix build with GCC14 update
fixes #367857
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.