Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

monero-cli: fix build issue with GCC14 #367932

Merged
merged 1 commit into from
Dec 26, 2024
Merged

Conversation

gador
Copy link
Member

@gador gador commented Dec 24, 2024

fix build with GCC14 update

fixes #367857

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@nix-owners nix-owners bot requested review from mmahut and RaghavSood December 24, 2024 14:40
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Dec 24, 2024
@gador gador changed the title monero-cli: 0.18.3.4 -> 0-unstable-2024-12-23 monero-cli,monero-gui: 0.18.3.4 -> 0-unstable-2024-12-23 Dec 24, 2024
@gador gador marked this pull request as draft December 24, 2024 20:19
@ofborg ofborg bot requested review from rnhmjoj and philipmw December 25, 2024 00:21
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 and removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin labels Dec 25, 2024
@gador gador changed the title monero-cli,monero-gui: 0.18.3.4 -> 0-unstable-2024-12-23 monero-cl: fix build issue with GCC14 Dec 25, 2024
@gador gador marked this pull request as ready for review December 25, 2024 09:31
@gador gador changed the title monero-cl: fix build issue with GCC14 monero-cli: fix build issue with GCC14 Dec 25, 2024
@gador
Copy link
Member Author

gador commented Dec 25, 2024

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 367932


x86_64-linux

❌ 2 packages failed to build:
  • haven-cli
  • haven-cli.source
✅ 4 packages built:
  • atomic-swap
  • monero-cli
  • monero-cli.source
  • monero-gui

aarch64-darwin

❌ 2 packages failed to build:
  • haven-cli
  • haven-cli.source

@gador
Copy link
Member Author

gador commented Dec 25, 2024

haven-cli fails on master, too

@ofborg ofborg bot requested a review from rnhmjoj December 26, 2024 08:44
Copy link
Contributor

@rnhmjoj rnhmjoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did the usual test: connect monero-gui to a remote node. Looks good.

@rnhmjoj rnhmjoj merged commit d6678a7 into NixOS:master Dec 26, 2024
40 of 41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build failure: monero-cli
2 participants