Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ofono: Fix patch to work under GCC 14 #368014

Merged
merged 1 commit into from
Dec 27, 2024
Merged

Conversation

OPNA2608
Copy link
Contributor

Merry Christmas! ofono was FTBFS on Hydra trunk since yesterday: https://hydra.nixos.org/build/282904835

This, along with what #367871 is fixing, is needed to un-break Lomiri DE builds again.

This package is in need of a bump too, but let's un-break the entirety of Lomiri first.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Dec 24, 2024
@OPNA2608
Copy link
Contributor Author

OPNA2608 commented Dec 25, 2024

@ofborg test lomiri

@OPNA2608
Copy link
Contributor Author

Ah, trust-store is still borked. Let's just try a single package then:

@ofborg build lomiri.lomiri-indicator-network

@fpletz fpletz merged commit 298d81a into NixOS:master Dec 27, 2024
46 of 49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants