-
-
Notifications
You must be signed in to change notification settings - Fork 14.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
opengamepadui: init at 0.35.7 #368017
base: master
Are you sure you want to change the base?
opengamepadui: init at 0.35.7 #368017
Conversation
09d3f7a
to
94d9142
Compare
7280eee
to
a6cdd74
Compare
95fbc21
to
1a85906
Compare
hardware.graphics = { | ||
# this fixes the "glXChooseVisual failed" bug, context: https://github.com/NixOS/nixpkgs/issues/47932 | ||
enable = true; | ||
enable32Bit = true; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This prevents use on aarch64-linux. Is it absolutely needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nixpkgs/nixos/modules/hardware/graphics.nix
Line 103 in bffc22e
assertion = cfg.enable32Bit -> pkgs.stdenv.hostPlatform.isx86_64; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then how about
enable32Bit = true; | |
enable32Bit = pkgs.stdenv.hostPlatform.isx86_64; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While this OpenGamepadUI derivation won't support aarch64-linux
right now, I'll add this suggestion so it will be ready when we can support that architecture.
description = "Open source gamepad-native game launcher and overlay"; | ||
homepage = "https://github.com/ShadowBlip/OpenGamepadUI"; | ||
license = lib.licenses.gpl3Only; | ||
platforms = lib.platforms.linux; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Makefile of OpenGamepadUI is tied to x86_64, so platforms should be restricted to just x86_64-linux
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It compiles on aarch64-linux, but it generates an x86_64-linux executable:
$ file /nix/store/*-opengamepadui-0.35.4/share/opengamepadui/opengamepad-ui.x86_64
/nix/store/0x13bbsy7jik93kh1ilkx5w2chf6sjx2-opengamepadui-0.35.4/share/opengamepadui/opengamepad-ui.x86_64: ELF 64-bit LSB executable, x86-64, version 1 (SYSV), dynamically linked, interpreter /lib64/ld-linux-x86-64.so.2, for GNU/Linux 5.15.0, stripped
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Arm support should be possible, but adding support for it will require a bit of work to factor out all of the architecture assumptions. Ideally OpenGamepadUI should also be paired with Gamescope, which I'm not sure works very well on arm at the moment.
I will update this to be x86_64-linux
only for now and hopefully can add arm support in the future.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I briefly looked into this. It looks like Godot right now only supports compiling to x86-64.
1a85906
to
6c6ce6e
Compare
Description of changes
Adds a derivation to run OpenGamepadUI on NixOS.
OpenGamepadUI is a free and open source game launcher and overlay written using the Godot Game Engine designed for a console-like, gamepad native experience in mind. Features include:
The gamescope session config for OpenGamepadUI is based off of the equivalent Steam gamescope session.
Things done
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.