wlcs,mir_2_15: Fix GCC 14 compat #368425
Merged
wlcs,mir_2_15: Fix GCC 14 compat #368425
+181
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
10.rebuild-darwin: 0
paparodeo
reviewed
Dec 27, 2024
pkgs/by-name/wl/wlcs/package.nix
Outdated
| @@ -38,6 +48,9 @@ stdenv.mkDerivation (finalAttrs: { | |||
| wayland-scanner # needed by cmake | |||
| ]; | |||
|
|
|||
| # Whatever default optimisation level is in use here (can reproduce with -O3) breaks std::function usage in some tests | |||
| env.NIX_CFLAGS_COMPILE = "-O2"; | |||
There was a problem hiding this comment.
seems like -Werror is enabled.
Suggested change
| env.NIX_CFLAGS_COMPILE = "-O2"; | |
| env.NIX_CFLAGS_COMPILE = lib.optionalString stdenv.cc.isGNU "-Wno-error=maybe-uninitialized"; |
I was able to get it to compile with out disabling the warning but it is weird.
5x.diff
diff --git a/tests/xdg_popup.cpp b/tests/xdg_popup.cpp
index 99c2a0b..41ee16d 100644
--- a/tests/xdg_popup.cpp
+++ b/tests/xdg_popup.cpp
@@ -734,6 +734,10 @@ INSTANTIATE_TEST_SUITE_P(
Default,
XdgPopupPositionerTest,
testing::Values(
+ PositionerTestParams{"default values", (window_width - popup_width) / 2, (window_height - popup_height) / 2, PositionerParams()},
+ PositionerTestParams{"default values", (window_width - popup_width) / 2, (window_height - popup_height) / 2, PositionerParams()},
+ PositionerTestParams{"default values", (window_width - popup_width) / 2, (window_height - popup_height) / 2, PositionerParams()},
+ PositionerTestParams{"default values", (window_width - popup_width) / 2, (window_height - popup_height) / 2, PositionerParams()},
PositionerTestParams{"default values", (window_width - popup_width) / 2, (window_height - popup_height) / 2, PositionerParams()}
));
There was a problem hiding this comment.
Might be this upstream issue? The explained situation there seems to be around LTO, but the error points at the same line…
Considering that the "fix" there was to just disable LTO in the Debian build code, and there are references to this being a compiler/linker issue, let's go with disabling the warning for now until upstream (whichever one that may be here) sorts that out.
ofborg
bot
added
the
11.by: package-maintainer
OPNA2608
force-pushed
the
fix/wlcs-gcc14
branch
from
5c4171d to
0e5a17a
Compare
paparodeo
approved these changes
Dec 27, 2024
|
@ofborg build mir mir.passthru.tests mir_2_15 mir_2_15.passthru.tests |
OPNA2608
added
the
12.approvals: 1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wlcs:
-O2to fix issue withstd::functionin testsI do not pretend to even comprehend what's going on there, so I'll just attach the full error and state that enforcing
-O0--O2makes the issue go away, and forcing-O3makes it re-appear. Maybe a regression in GCC?Welcome to C++ hell
mir_2_15:
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.