taskwarrior3: fix version and add versionCheckHook test #368520
Conversation
Signed-off-by: Fernando Rodrigues <[email protected]>
…ismatches. Signed-off-by: Fernando Rodrigues <[email protected]>
SigmaSquadron
requested review from
MarcWeber,
doronbehar,
oxalica and
mlaradji
| versionCheckHook | ||
| ]; | ||
|
|
||
| versionCheckProgram = "${placeholder "out"}/bin/${finalAttrs.meta.mainProgram}"; |
There was a problem hiding this comment.
| versionCheckProgram = "${placeholder "out"}/bin/${finalAttrs.meta.mainProgram}"; | |
| versionCheckProgram = "${placeholder "out"}/bin/task"; |
I remember someone somewhere saying that finalAttrs.meta.* is a bad idea for some reason. I can't remember why, or if it's even a anti-pattern in the first place, but do let me know if this should be changed.
There was a problem hiding this comment.
I remember someone somewhere saying that
finalAttrs.meta.*is a bad idea for some reason. I can't remember why, or if it's even a anti-pattern in the first place, but do let me know if this should be changed.
I too heard that said, and TBH I'm not very good at explaining why. I heard that though mostly about src and pname as the repo argument, and here I think it is a bit different. I won't make this a blocker, as the rest of the PR is perfect.
Upstream links to the releases instead of the changelog file: https://taskwarrior.org/news/news.20241219/ Signed-off-by: Fernando Rodrigues <[email protected]>
| rev = "v${finalAttrs.version}"; | ||
| hash = "sha256-aKDwRCJ1yopRdsPxnHhgOpSho1i8/dcAurI+XhpSbn4="; |
There was a problem hiding this comment.
Oh thanks! I counted on nix-update to the job for me, even when the current version is "unstable".
| versionCheckHook | ||
| ]; | ||
|
|
||
| versionCheckProgram = "${placeholder "out"}/bin/${finalAttrs.meta.mainProgram}"; |
There was a problem hiding this comment.
I remember someone somewhere saying that
finalAttrs.meta.*is a bad idea for some reason. I can't remember why, or if it's even a anti-pattern in the first place, but do let me know if this should be changed.
I too heard that said, and TBH I'm not very good at explaining why. I heard that though mostly about src and pname as the repo argument, and here I think it is a bit different. I won't make this a blocker, as the rest of the PR is perfect.
Fixes #368467
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.