Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/swapspace: add installWrapper option #368539

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

nixos/swapspace: add installWrapper option #368539

wants to merge 2 commits into from
+48 −19

Conversation

phanirithvij
Copy link
Member

@phanirithvij phanirithvij commented Dec 27, 2024 •
edited
Loading

fixes #368492

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Dec 27, 2024
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Dec 27, 2024
@phanirithvij @Luflosi
nixos/swapspace: add installWrapper option
64b06b0 
Signed-off-by: phanirithvij <[email protected]>
Co-authored-by: Luflosi <[email protected]>
@phanirithvij
swapspace: refactor
848da53 
Signed-off-by: phanirithvij <[email protected]>
@phanirithvij
Copy link
Member Author

I've taken the liberty to refactor swapspace package derivation. It builds with the same hash as before.

Luflosi
Luflosi approved these changes Dec 27, 2024
View reviewed changes
Copy link
Contributor

@Luflosi Luflosi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@phanirithvij
Copy link
Member Author

phanirithvij commented Dec 27, 2024 •
edited
Loading

@ofborg build nixosTests.swapspace

@phanirithvij phanirithvij added 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package labels Dec 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SigmaSquadron SigmaSquadron SigmaSquadron left review comments

@Luflosi Luflosi Luflosi approved these changes

@r-vdp r-vdp Awaiting requested review from r-vdp

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Swapspace option not properly configured out of box?
3 participants
@phanirithvij @Luflosi @SigmaSquadron