Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spotube: 3.8.3 -> 3.9.0 #368544

Closed
wants to merge 1 commit into from
Closed

Conversation

damidoug
Copy link

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@NixOSInfra NixOSInfra added the 12. first-time contribution This PR is the author's first one; please be gentle! label Dec 27, 2024
@MisileLab
Copy link
Contributor

please change title and commit message to 'spotube: 3.8.3 -> 3.9.0'

@damidoug damidoug changed the title 3.8.3 > 3.9.0 spotube: 3.8.3 -> 3.9.0 Dec 27, 2024
@MisileLab
Copy link
Contributor

also see this for how to add maintainers.

@damidoug
Copy link
Author

I added.

@MisileLab
Copy link
Contributor

I added.

You need to add yourself to maintainers.nix.

@damidoug
Copy link
Author

done: pull/368547

@damidoug
Copy link
Author

Why not passes on checks @MisileLab ?

@damidoug damidoug closed this Dec 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
12. first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants