Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.loguru: 0.7.2 -> 0.7.3 & cleanups #368660

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

python3Packages.loguru: 0.7.2 -> 0.7.3 & cleanups #368660

wants to merge 1 commit into from
+17 −12

Conversation

PerchunPak
Copy link
Member

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • [x ] x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

CC @jbaum98 @rmcgibbo

Add a 👍 reaction to pull requests you find important.

PerchunPak
PerchunPak commented Dec 27, 2024
View reviewed changes
pkgs/development/python-modules/loguru/default.nix

disabledTestPaths = [
"tests/test_type_hinting.py" # avoid dependency on mypy
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pytest-mypy-plugins was used in conftest, so dependency on mypy seemed unavoidable

@ofborg ofborg bot requested review from jbaum98 and rmcgibbo December 28, 2024 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbaum98 jbaum98 Awaiting requested review from jbaum98

@rmcgibbo rmcgibbo Awaiting requested review from rmcgibbo

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@PerchunPak