python3Packages.loguru: 0.7.2 -> 0.7.3 & cleanups #368660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PerchunPak
force-pushed
the
loguru-update
branch
from
cd92499 to
01ea54b
Compare
PerchunPak
commented
Dec 27, 2024
|
|
||
| disabledTestPaths = [ | ||
| "tests/test_type_hinting.py" # avoid dependency on mypy |
There was a problem hiding this comment.
pytest-mypy-plugins was used in conftest, so dependency on mypy seemed unavoidable
|
|
Everything that fails here, fails on master too. |
|
Successfully created backport PR for |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)CC @jbaum98 @rmcgibbo
Add a 👍 reaction to pull requests you find important.