Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

threema-desktop: fix build #368813

Closed
wants to merge 1 commit into from
Closed

threema-desktop: fix build #368813

wants to merge 1 commit into from

Conversation

flokli
Copy link
Contributor

@flokli flokli commented Dec 28, 2024

The threema-web build fails with nodejs_22, setting it back to 20 fixes the build.

Successfully connected to a phone with it.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@flokli
threema-desktop: fix build
6e2b069 
The threema-web build fails with nodejs_22, setting it back to
20 fixes the build.
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Dec 28, 2024
flokli added a commit to flokli/nixpkgs that referenced this pull request Dec 28, 2024
@flokli
threema-desktop: 2.5.3 -> 2.5.7
e97955f 
This fixes the build otherwise broken with nodejs 22 in the old version.

Alternative to NixOS#368813
@flokli flokli mentioned this pull request Dec 28, 2024
Merged
13 tasks
@flokli flokli requested a review from dotlambda December 28, 2024 13:50
@flokli
Copy link
Contributor Author

flokli commented Dec 28, 2024

Closing in favor of #368819.

@flokli flokli closed this Dec 28, 2024
@flokli flokli deleted the threema-fix-build branch December 28, 2024 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dotlambda dotlambda Awaiting requested review from dotlambda

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@flokli