Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lnav: fix cross compilation #368825

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

lnav: fix cross compilation #368825

wants to merge 1 commit into from
+14 −1

Conversation

symphorien
Copy link
Member

tested from x86_64 to armv8 and armv7

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@misuzu misuzu added the 6.topic: cross-compilation Building packages on a different platform than they will be used on label Dec 28, 2024
@ofborg ofborg bot requested a review from pcasaretto December 28, 2024 17:08
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1 10.rebuild-linux: 1 labels Dec 28, 2024
@symphorien symphorien marked this pull request as draft December 28, 2024 20:21
@symphorien
Copy link
Member Author

Upstream has feedback on the patch, marking as draft

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pcasaretto pcasaretto Awaiting requested review from pcasaretto

Assignees
No one assigned
Labels
6.topic: cross-compilation Building packages on a different platform than they will be used on 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@symphorien @misuzu