Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

patool: 2.4.0 -> 3.1.0 #368882

Merged
merged 1 commit into from
Dec 29, 2024
Merged

patool: 2.4.0 -> 3.1.0 #368882

merged 1 commit into from
Dec 29, 2024

Conversation

MisileLab
Copy link
Contributor

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@MisileLab
patool: 2.4.0 -> 3.1.0
5a55fd0 
Signed-off-by: misilelab <[email protected]>
@Scrumplex
Copy link
Member

Scrumplex commented Dec 29, 2024 •
edited
Loading

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 368882

x86_64-linux

❌ 12 packages failed to build:
  • portmod
  • portmod.dist
  • python312Packages.heudiconv
  • python312Packages.heudiconv.dist
  • python313Packages.datalad
  • python313Packages.datalad-gooey
  • python313Packages.datalad-gooey.dist
  • python313Packages.datalad-next
  • python313Packages.datalad-next.dist
  • python313Packages.datalad.dist
  • python313Packages.pyunpack
  • python313Packages.pyunpack.dist
✅ 14 packages built:
  • bottles
  • bottles-unwrapped
  • datalad (python312Packages.datalad)
  • datalad-gooey (python312Packages.datalad-gooey)
  • datalad-gooey.dist (python312Packages.datalad-gooey.dist)
  • datalad.dist (python312Packages.datalad.dist)
  • patool (python312Packages.patool)
  • patool.dist (python312Packages.patool.dist)
  • python312Packages.datalad-next
  • python312Packages.datalad-next.dist
  • python312Packages.pyunpack
  • python312Packages.pyunpack.dist
  • python313Packages.patool
  • python313Packages.patool.dist

x86_64-darwin

❌ 10 packages failed to build:
  • python312Packages.heudiconv
  • python312Packages.heudiconv.dist
  • python313Packages.datalad
  • python313Packages.datalad-gooey
  • python313Packages.datalad-gooey.dist
  • python313Packages.datalad-next
  • python313Packages.datalad-next.dist
  • python313Packages.datalad.dist
  • python313Packages.pyunpack
  • python313Packages.pyunpack.dist
✅ 12 packages built:
  • datalad (python312Packages.datalad)
  • datalad-gooey (python312Packages.datalad-gooey)
  • datalad-gooey.dist (python312Packages.datalad-gooey.dist)
  • datalad.dist (python312Packages.datalad.dist)
  • patool (python312Packages.patool)
  • patool.dist (python312Packages.patool.dist)
  • python312Packages.datalad-next
  • python312Packages.datalad-next.dist
  • python312Packages.pyunpack
  • python312Packages.pyunpack.dist
  • python313Packages.patool
  • python313Packages.patool.dist

aarch64-darwin

❌ 10 packages failed to build:
  • python312Packages.heudiconv
  • python312Packages.heudiconv.dist
  • python313Packages.datalad
  • python313Packages.datalad-gooey
  • python313Packages.datalad-gooey.dist
  • python313Packages.datalad-next
  • python313Packages.datalad-next.dist
  • python313Packages.datalad.dist
  • python313Packages.pyunpack
  • python313Packages.pyunpack.dist
✅ 12 packages built:
  • datalad (python312Packages.datalad)
  • datalad-gooey (python312Packages.datalad-gooey)
  • datalad-gooey.dist (python312Packages.datalad-gooey.dist)
  • datalad.dist (python312Packages.datalad.dist)
  • patool (python312Packages.patool)
  • patool.dist (python312Packages.patool.dist)
  • python312Packages.datalad-next
  • python312Packages.datalad-next.dist
  • python312Packages.pyunpack
  • python312Packages.pyunpack.dist
  • python313Packages.patool
  • python313Packages.patool.dist

Edit: portmod failures are unrelated. See #353324

@Scrumplex Scrumplex merged commit 7fa1a3c into NixOS:master Dec 29, 2024
40 of 41 checks passed
@MisileLab MisileLab deleted the patool branch December 29, 2024 12:38
builtbyvys added a commit to builtbyvys/nix-dotfiles that referenced this pull request Dec 29, 2024
@builtbyvys
bug(patool): pinned patool to 3.1.0 to fix building (NixOS/nixpkgs#36…
327c6a0 
…8882)
@Gliczy Gliczy mentioned this pull request Dec 29, 2024
Closed
@malikwirin
Copy link
Contributor

Can we have this in 24.11?

@MisileLab MisileLab mentioned this pull request Dec 30, 2024
Merged
13 tasks
@MisileLab
Copy link
Contributor Author

Can we have this in 24.11?

I made #369412

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/patool-does-not-build-failed-test/57964/4

@malikwirin malikwirin mentioned this pull request Jan 5, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Scrumplex Scrumplex Scrumplex approved these changes

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Build failure: python312Packages.patool
4 participants
@MisileLab @Scrumplex @malikwirin @nixos-discourse