include-what-you-use: 0.22 -> 0.23 #369857
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
winterqt
reviewed
Jan 15, 2025
Comment on lines
15
to
19
| src = fetchurl { | ||
| url = "${meta.homepage}/downloads/${pname}-${version}.src.tar.gz"; | ||
| hash = "sha256-hZB0tGHqS4MlpzQYwgfKM7XmVmsI5rWH65FkQWVppt0="; | ||
| src = fetchFromGitHub { | ||
| owner = "include-what-you-use"; | ||
| repo = "include-what-you-use"; | ||
| tag = version; | ||
| hash = "sha256-djL1nfyVvkB+qnms8t2kVEZfJVvYWzLA1lpmznJCPsU="; | ||
| }; |
There was a problem hiding this comment.
Arguably we might want to keep using the upstream-provided source tarballs.
There was a problem hiding this comment.
Okay, I'll switch it back.
There was a problem hiding this comment.
Should fetchurl be changed to fetchzip?
ja1den
force-pushed
the
update-include-what-you-use
branch
from
333ec27 to
b88ce51
Compare
ja1den
force-pushed
the
update-include-what-you-use
branch
from
b88ce51 to
e368014
Compare
ja1den
force-pushed
the
update-include-what-you-use
branch
from
e368014 to
1fef952
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/include-what-you-use/include-what-you-use/releases/tag/0.23
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.