Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mise: add usage compatibility test #369951

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

konradmalik
Copy link
Contributor

@konradmalik konradmalik commented Jan 1, 2025

See: #369472 and #369640

This adds a test which checks if the current usage in nixpkgs does not crash when called with the current mise's schema.

See that in bd5b7b0 this test fails with the same error as in the issue, but in af7f273 it passes.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@konradmalik konradmalik added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 8.has: tests This PR has tests 2.status: blocked by pr/issue Another PR or issue is preventing this from being completed labels Jan 1, 2025
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 and removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Jan 1, 2025
@konradmalik konradmalik force-pushed the mise branch 3 times, most recently from bd5b7b0 to af7f273 Compare January 1, 2025 13:21
@konradmalik
Copy link
Contributor Author

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 369951


x86_64-linux

✅ 2 packages built:
  • mise
  • usage

@konradmalik konradmalik force-pushed the mise branch 2 times, most recently from 2ecc76d to 0c02358 Compare January 9, 2025 07:42
@konradmalik konradmalik removed the 2.status: blocked by pr/issue Another PR or issue is preventing this from being completed label Jan 11, 2025
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux and removed 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Jan 11, 2025
@konradmalik konradmalik marked this pull request as draft January 14, 2025 08:23
@konradmalik konradmalik marked this pull request as ready for review January 14, 2025 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: tests This PR has tests 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant