Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

various: fix cross / strictDeps build #370256

Merged
merged 13 commits into from
Jan 11, 2025
Merged

various: fix cross / strictDeps build #370256

merged 13 commits into from
Jan 11, 2025

Conversation

FliegendeWurst
Copy link
Member

@FliegendeWurst FliegendeWurst commented Jan 2, 2025 •
edited
Loading

All done in one PR since the fixes are straight-forward mostly. Let me know if I should split the changes into multiple PRs.

ref. #178468

Things done

  • Built on platform(s)
    • x86_64-linux: regular and cross to aarch64 (where possible)
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Fits CONTRIBUTING.md.

@FliegendeWurst FliegendeWurst added the 6.topic: cross-compilation Building packages on a different platform than they will be used on label Jan 2, 2025
@emilazy
Copy link
Member

emilazy commented Jan 5, 2025

Maybe split out the new package to be reviewed separately so that this is just fixes?

veprbl
veprbl approved these changes Jan 5, 2025
View reviewed changes
Copy link
Member

@veprbl veprbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff LGTM

@wegank wegank added 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package labels Jan 5, 2025
emilazy
emilazy approved these changes Jan 5, 2025
View reviewed changes
Copy link
Member

@emilazy emilazy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Commit message of 77fb8f4 is now inaccurate but not a blocker.

Bot-wxt1221
Bot-wxt1221 approved these changes Jan 6, 2025
View reviewed changes
Copy link
Member

@Bot-wxt1221 Bot-wxt1221 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Now lvtk is called with <lvtk/lvtk.h>.

@wegank wegank added 12.approvals: 2 This PR was reviewed and approved by two reputable people and removed 12.approvals: 1 This PR was reviewed and approved by one reputable person labels Jan 6, 2025
7c6f434c
7c6f434c approved these changes Jan 7, 2025
View reviewed changes
Copy link
Member

@7c6f434c 7c6f434c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable but I am not up to date about anything interesting in cross-compilation

@wegank wegank added 12.approvals: 3+ This PR was reviewed and approved by three or more reputable people and removed 12.approvals: 2 This PR was reviewed and approved by two reputable people labels Jan 7, 2025
@FliegendeWurst FliegendeWurst merged commit e35846f into NixOS:staging Jan 11, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uninsane uninsane uninsane left review comments

@emilazy emilazy emilazy approved these changes

@Bot-wxt1221 Bot-wxt1221 Bot-wxt1221 approved these changes

@7c6f434c 7c6f434c 7c6f434c approved these changes

@veprbl veprbl veprbl approved these changes

@lovek323 lovek323 Awaiting requested review from lovek323

@Shiphan Shiphan Awaiting requested review from Shiphan

Assignees
No one assigned
Labels
6.topic: cross-compilation Building packages on a different platform than they will be used on 10.rebuild-darwin: 101-500 10.rebuild-linux: 1001-2500 12.approvals: 3+ This PR was reviewed and approved by three or more reputable people 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@FliegendeWurst @emilazy @veprbl @7c6f434c @Bot-wxt1221 @uninsane @wegank