Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ffizer: init at 2.13.1 #370378

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

ffizer: init at 2.13.1 #370378

wants to merge 1 commit into from
+51 −0

Conversation

XBagon
Copy link
Contributor

@XBagon XBagon commented Jan 2, 2025 •
edited
Loading

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Lurkki14
Lurkki14 suggested changes Jan 3, 2025
View reviewed changes
pkgs/by-name/ff/ffizer/package.nix Outdated Show resolved Hide resolved
@XBagon XBagon requested a review from Lurkki14 January 3, 2025 14:16
@Lurkki14 Lurkki14 added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Jan 3, 2025
@lucasew
Copy link
Contributor

lucasew commented Jan 4, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 370378

x86_64-linux

✅ 1 package built:
  • ffizer

FliegendeWurst
FliegendeWurst reviewed Jan 11, 2025
View reviewed changes
pkgs/by-name/ff/ffizer/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/ff/ffizer/package.nix Outdated Show resolved Hide resolved
@FliegendeWurst
Copy link
Member

One test is failing. https://paste.fliegendewurst.eu/dLeV3d.log

failures:
---- git::git2::tests::retrieve_should_update_existing_template stdout ----
thread 'git::git2::tests::retrieve_should_update_existing_template' panicked at src/git/git2.rs:102:14:
setting default subscriber failed: SetGlobalDefaultError("a global default trace dispatcher has already been set")
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
failures:
    git::git2::tests::retrieve_should_update_existing_template

@XBagon XBagon mentioned this pull request Jan 12, 2025
Closed
@wegank wegank removed the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Jan 12, 2025
@XBagon XBagon changed the title ffizer: init at 2.13.0 ffizer: init at 2.13.1 Jan 13, 2025
@XBagon
ffizer: init at 2.13.1
377ca5c 
ffizer: init at 2.13.0

Apply suggestions from review

Co-authored-by: Arne Keller <[email protected]>

run tests consecutively to circumvent ffizer/ffizer#779
@XBagon XBagon requested a review from Lurkki14 January 13, 2025 21:23
@XBagon

This comment was marked as resolved.

Sign in to view
@FliegendeWurst
Copy link
Member

Think you have to wait for Eval to finish before using nixpkgs-review

@XBagon
Copy link
Contributor Author

XBagon commented Jan 13, 2025

Think you have to wait for Eval to finish before using nixpkgs-review

Thanks for the right direction. Mic92/nixpkgs-review#454
Seems like I just have to use the version 3.0.1 (from unstable), because it's --eval=github now?

@FliegendeWurst
Copy link
Member

Yes. There are plans to backport the new version. #373534

@XBagon
Copy link
Contributor Author

XBagon commented Jan 14, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 370378

x86_64-linux

✅ 1 package built:
  • ffizer

@wegank wegank added the 12.approvals: 2 This PR was reviewed and approved by two reputable people label Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FliegendeWurst FliegendeWurst FliegendeWurst approved these changes

@Lurkki14 Lurkki14 Awaiting requested review from Lurkki14

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12.approvals: 2 This PR was reviewed and approved by two reputable people
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@XBagon @lucasew @FliegendeWurst @Lurkki14 @wegank