Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ardour_7: fix dependencies #370642

Merged
merged 1 commit into from
Jan 4, 2025
Merged

ardour_7: fix dependencies #370642

merged 1 commit into from
Jan 4, 2025

Conversation

korrat
Copy link
Contributor

@korrat korrat commented Jan 3, 2025

Follow up from #369048.

ardour_7 had an outdated dependency on librdf_raptor, which this patch removes in favour of propagated build inputs from librdf_rasqual.

Also pins boost to version 1.83, to avoid a build failure due to a newly added overload in boost 1.85.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Jan 3, 2025
@emilazy
Copy link
Member

emilazy commented Jan 3, 2025

Try fetchpatching Ardour/ardour@f94bde5 rather than pinning Boost; I just got rid of all the other uses of 1.83 :)

@lucasew
Copy link
Contributor

lucasew commented Jan 3, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 370642


x86_64-linux

✅ 1 package built:
  • ardour_7

@korrat korrat force-pushed the fix-ardour7-gcc14 branch 2 times, most recently from 608501a to f47f1f5 Compare January 4, 2025 13:19
`ardour_7` had an outdated dependency on `librdf_raptor`, which this
patch removes in favour of propagated build inputs from `librdf_rasqual`.

Also adds a patch, to avoid a build failure due to a newly added overload
in `boost` 1.85.
@korrat korrat force-pushed the fix-ardour7-gcc14 branch from f47f1f5 to a28c17d Compare January 4, 2025 13:28
@korrat
Copy link
Contributor Author

korrat commented Jan 4, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review


x86_64-linux

✅ 1 package built:
  • ardour_7

Copy link
Member

@emilazy emilazy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks! Do you want to do the honours of removing the broken package now or shall I?

@emilazy emilazy merged commit c87e3c7 into NixOS:master Jan 4, 2025
38 checks passed
@korrat korrat deleted the fix-ardour7-gcc14 branch January 5, 2025 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants