python3Packages.fastjet: re-init at 3.4.2.1 #370858

veprbl · 2025-01-04T13:52:19Z

The fastjet package in pypi namespace is an "official" python package that vendors FastJet with its SWIG bindings. That vendoring is broken wrt macOS install_name, so this package implements unvendoring. The package is replaces the SWIG bindings, as it should provide a compatible API.

Things done

Add a 👍 reaction to pull requests you find important.

lucasew · 2025-01-04T16:57:59Z

`nixpkgs-review` result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 370858

`x86_64-linux`

❌ 2 packages failed to build:

python312Packages.fastjet
python312Packages.fastjet.dist

lucasew · 2025-01-04T17:15:11Z

Logs

error: builder for '/nix/store/5wkc1x20w39h2fgas5b714di9xxsmq92-python3.12-awkward-2.7.2.drv' failed with exit code 1;
       last 25 log lines:
       > SKIPPED [1] tests/test_3292_to_tensorflow_from_tensorflow.py:13: could not import 'tensorflow': No module named 'tensorflow'
       > SKIPPED [1] tests/test_0652_tests_of_complex_numbers.py:220: Remember to implement sorting for complex numbers.
       > SKIPPED [1] tests/test_0115_generic_reducer_operation.py:1211: I can't think of a canonical UnionArray (non-mergeable contents) that can be used in a reducer
       > SKIPPED [1] tests/test_1072_sort.py:716: I can't think of a canonical UnionArray (non-mergeable contents) that can be used in sorting
       > SKIPPED [1] tests/test_1072_sort.py:741: I can't think of a canonical UnionArray (non-mergeable contents) that can be used in sorting
       > SKIPPED [1] tests/test_1672_broadcast_parameters.py:11: string broadcasting is broken
       > SKIPPED [1] tests/test_1672_broadcast_parameters.py:25: string broadcasting is broken
       > SKIPPED [1] tests/test_1672_broadcast_parameters.py:39: string broadcasting is broken
       > SKIPPED [1] tests/test_1672_broadcast_parameters.py:57: string broadcasting is broken
       > SKIPPED [4] tests/test_1440_start_v2_to_parquet.py:224: Categorical arrays can't roundtrip through Parquet due to ARROW-14525
       > SKIPPED [1] tests/test_2297_common_backend.py:58: could not import 'ROOT': No module named 'ROOT'
       > SKIPPED [1] tests/test_1764_jax_jacobian.py:16: Jacobian support not implemented
       > SKIPPED [2] tests/test_2793_nep_50_gradual_support.py:44: NumPy >= 1.24.0 has NEP-50 support
       > SKIPPED [1] tests/test_2799_numba_ufunc_resolution.py:39: Numba has NEP-50 support
       > FAILED tests/test_1447_jax_autodiff_slices_ufuncs.py::test_regular_array_4 - jax.errors.UnexpectedTracerError: Encountered an unexpected tracer. A funct...
       > FAILED tests/test_1447_jax_autodiff_slices_ufuncs.py::test_regular_array_5 - jax.errors.UnexpectedTracerError: Encountered an unexpected tracer. A funct...
       > FAILED tests/test_1447_jax_autodiff_slices_ufuncs.py::test_regular_array_2 - jax.errors.UnexpectedTracerError: Encountered an unexpected tracer. A funct...
       > FAILED tests/test_1447_jax_autodiff_slices_ufuncs.py::test_recordarray_4 - jax.errors.UnexpectedTracerError: Encountered an unexpected tracer. A funct...
       > FAILED tests/test_1447_jax_autodiff_slices_ufuncs.py::test_recordarray_5 - jax.errors.UnexpectedTracerError: Encountered an unexpected tracer. A funct...
       > FAILED tests/test_1447_jax_autodiff_slices_ufuncs.py::test_recordarray_6 - jax.errors.UnexpectedTracerError: Encountered an unexpected tracer. A funct...
       > FAILED tests/test_1490_jax_reducers_combinations.py::test_reducer[min-0] - jax.errors.UnexpectedTracerError: Encountered an unexpected tracer. A funct...
       > FAILED tests/test_1490_jax_reducers_combinations.py::test_reducer[min-1] - jax.errors.UnexpectedTracerError: Encountered an unexpected tracer. A funct...
       > FAILED tests/test_1490_jax_reducers_combinations.py::test_reducer[max-0] - jax.errors.UnexpectedTracerError: Encountered an unexpected tracer. A funct...
       > FAILED tests/test_1490_jax_reducers_combinations.py::test_reducer[max-1] - jax.errors.UnexpectedTracerError: Encountered an unexpected tracer. A funct...
       > ============ 10 failed, 2957 passed, 36 skipped in 63.03s (0:01:03) ============

lucasew · 2025-01-04T20:54:58Z

`nixpkgs-review` result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 370858

`x86_64-linux`

❌ 2 packages failed to build:

python312Packages.fastjet
python312Packages.fastjet.dist

veprbl · 2025-01-05T15:49:23Z

@GaetanLepage I'd like to stop testing with JAX. I personally don't have interest in supporting this feature, and it's a large dependency.

veprbl · 2025-01-05T16:31:17Z

Result of nixpkgs-review pr 370858 run on x86_64-linux 1

18 packages built:

python312Packages.awkward
python312Packages.awkward-pandas
python312Packages.awkward-pandas.dist
python312Packages.awkward.dist
python312Packages.coffea
python312Packages.coffea.dist
python312Packages.correctionlib
python312Packages.correctionlib.dist
python312Packages.dask-awkward
python312Packages.dask-awkward.dist
python312Packages.fastjet
python312Packages.fastjet.dist
python312Packages.mplhep
python312Packages.mplhep.dist
python312Packages.uproot
python312Packages.uproot.dist
python312Packages.vector
python312Packages.vector.dist

GaetanLepage · 2025-01-05T18:17:06Z

@GaetanLepage I'd like to stop testing with JAX. I personally don't have interest in supporting this feature, and it's a large dependency.

Fine by me. You can disable the affected tests ?

veprbl · 2025-01-05T19:22:39Z

Yes, it's just one test file, the one that we disable for darwin.

GaetanLepage · 2025-01-08T21:02:50Z

It looks like there is a formatting issue.

veprbl · 2025-01-08T22:24:38Z

Result of nixpkgs-review pr 370858 run on x86_64-linux 1

18 packages built:

python312Packages.awkward
python312Packages.awkward-pandas
python312Packages.awkward-pandas.dist
python312Packages.awkward.dist
python312Packages.coffea
python312Packages.coffea.dist
python312Packages.correctionlib
python312Packages.correctionlib.dist
python312Packages.dask-awkward
python312Packages.dask-awkward.dist
python312Packages.fastjet
python312Packages.fastjet.dist
python312Packages.mplhep
python312Packages.mplhep.dist
python312Packages.uproot
python312Packages.uproot.dist
python312Packages.vector
python312Packages.vector.dist

pkgs/development/python-modules/fastjet/default.nix

GaetanLepage · 2025-01-08T22:57:20Z

`nixpkgs-review` result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 370858

`x86_64-linux`

❌ 2 packages failed to build:

python312Packages.coffea
python312Packages.coffea.dist

✅ 16 packages built:

python312Packages.awkward
python312Packages.awkward-pandas
python312Packages.awkward-pandas.dist
python312Packages.awkward.dist
python312Packages.correctionlib
python312Packages.correctionlib.dist
python312Packages.dask-awkward
python312Packages.dask-awkward.dist
python312Packages.fastjet
python312Packages.fastjet.dist
python312Packages.mplhep
python312Packages.mplhep.dist
python312Packages.uproot
python312Packages.uproot.dist
python312Packages.vector
python312Packages.vector.dist

`aarch64-linux`

✅ 18 packages built:

python312Packages.awkward
python312Packages.awkward-pandas
python312Packages.awkward-pandas.dist
python312Packages.awkward.dist
python312Packages.coffea
python312Packages.coffea.dist
python312Packages.correctionlib
python312Packages.correctionlib.dist
python312Packages.dask-awkward
python312Packages.dask-awkward.dist
python312Packages.fastjet
python312Packages.fastjet.dist
python312Packages.mplhep
python312Packages.mplhep.dist
python312Packages.uproot
python312Packages.uproot.dist
python312Packages.vector
python312Packages.vector.dist

`x86_64-darwin`

❌ 4 packages failed to build:

python312Packages.coffea
python312Packages.coffea.dist
python312Packages.fastjet
python312Packages.fastjet.dist

✅ 2 packages built:

python312Packages.correctionlib
python312Packages.correctionlib.dist

`aarch64-darwin`

❌ 4 packages failed to build:

python312Packages.coffea
python312Packages.coffea.dist
python312Packages.fastjet
python312Packages.fastjet.dist

✅ 2 packages built:

python312Packages.correctionlib
python312Packages.correctionlib.dist

pkgs/development/python-modules/fastjet/default.nix

veprbl · 2025-01-08T23:25:10Z

Result of nixpkgs-review pr 370858 run on x86_64-linux 1

18 packages built:

python312Packages.awkward
python312Packages.awkward-pandas
python312Packages.awkward-pandas.dist
python312Packages.awkward.dist
python312Packages.coffea
python312Packages.coffea.dist
python312Packages.correctionlib
python312Packages.correctionlib.dist
python312Packages.dask-awkward
python312Packages.dask-awkward.dist
python312Packages.fastjet
python312Packages.fastjet.dist
python312Packages.mplhep
python312Packages.mplhep.dist
python312Packages.uproot
python312Packages.uproot.dist
python312Packages.vector
python312Packages.vector.dist

GaetanLepage · 2025-01-08T23:39:38Z

`nixpkgs-review` result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 370858

`x86_64-linux`

❌ 2 packages failed to build:

python312Packages.coffea
python312Packages.coffea.dist

✅ 16 packages built:

python312Packages.awkward
python312Packages.awkward-pandas
python312Packages.awkward-pandas.dist
python312Packages.awkward.dist
python312Packages.correctionlib
python312Packages.correctionlib.dist
python312Packages.dask-awkward
python312Packages.dask-awkward.dist
python312Packages.fastjet
python312Packages.fastjet.dist
python312Packages.mplhep
python312Packages.mplhep.dist
python312Packages.uproot
python312Packages.uproot.dist
python312Packages.vector
python312Packages.vector.dist

`aarch64-linux`

✅ 18 packages built:

python312Packages.awkward
python312Packages.awkward-pandas
python312Packages.awkward-pandas.dist
python312Packages.awkward.dist
python312Packages.coffea
python312Packages.coffea.dist
python312Packages.correctionlib
python312Packages.correctionlib.dist
python312Packages.dask-awkward
python312Packages.dask-awkward.dist
python312Packages.fastjet
python312Packages.fastjet.dist
python312Packages.mplhep
python312Packages.mplhep.dist
python312Packages.uproot
python312Packages.uproot.dist
python312Packages.vector
python312Packages.vector.dist

`x86_64-darwin`

❌ 4 packages failed to build:

python312Packages.coffea
python312Packages.coffea.dist
python312Packages.fastjet
python312Packages.fastjet.dist

✅ 2 packages built:

python312Packages.correctionlib
python312Packages.correctionlib.dist

`aarch64-darwin`

❌ 4 packages failed to build:

python312Packages.coffea
python312Packages.coffea.dist
python312Packages.fastjet
python312Packages.fastjet.dist

✅ 2 packages built:

python312Packages.correctionlib
python312Packages.correctionlib.dist

GaetanLepage · 2025-01-08T23:41:57Z

coffea failures on linux are caused by a single flaky test. Let's ignore them for now.

GaetanLepage

LGTM thanks :)

veprbl · 2025-01-09T00:28:33Z

python3Packages.fastjet fails on darwin because of a regression with building fastjet, let's deal with that separately.

github-actions bot added the 6.topic: python label Jan 4, 2025

nix-owners bot requested a review from natsukium January 4, 2025 13:54

github-actions bot added 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Jan 4, 2025

veprbl force-pushed the pr/fastjet_reinit_3_4_2_1 branch from 4416567 to ad3b4db Compare January 4, 2025 14:09

veprbl mentioned this pull request Jan 8, 2025

python312Packages.awkward: skip failing tests #372157

Closed

13 tasks

veprbl force-pushed the pr/fastjet_reinit_3_4_2_1 branch from e244236 to fde6a99 Compare January 8, 2025 22:18

GaetanLepage reviewed Jan 8, 2025

View reviewed changes

veprbl force-pushed the pr/fastjet_reinit_3_4_2_1 branch 2 times, most recently from e567921 to 2a38243 Compare January 8, 2025 22:38

GaetanLepage reviewed Jan 8, 2025

View reviewed changes

pkgs/development/python-modules/fastjet/default.nix Outdated Show resolved Hide resolved

veprbl added 3 commits January 8, 2025 18:19

python3Packages.fastjet: re-init at 3.4.2.1

c89f023

python3Packages.awkward: disable testing against JAX

a4ba9bc

python3Packages.correctionlib: patch vendored rapidjson

7dfdc35

veprbl force-pushed the pr/fastjet_reinit_3_4_2_1 branch from 1c44c50 to 7dfdc35 Compare January 8, 2025 23:19

GaetanLepage approved these changes Jan 8, 2025

View reviewed changes

wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Jan 8, 2025

veprbl merged commit c654b53 into NixOS:master Jan 9, 2025
23 checks passed

veprbl deleted the pr/fastjet_reinit_3_4_2_1 branch January 9, 2025 00:28

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

python3Packages.fastjet: re-init at 3.4.2.1 #370858

python3Packages.fastjet: re-init at 3.4.2.1 #370858

veprbl commented Jan 4, 2025

lucasew commented Jan 4, 2025

lucasew commented Jan 4, 2025

lucasew commented Jan 4, 2025

veprbl commented Jan 5, 2025 •

edited

Loading

veprbl commented Jan 5, 2025

GaetanLepage commented Jan 5, 2025

veprbl commented Jan 5, 2025

GaetanLepage commented Jan 8, 2025

veprbl commented Jan 8, 2025

GaetanLepage commented Jan 8, 2025

veprbl commented Jan 8, 2025

GaetanLepage commented Jan 8, 2025

GaetanLepage commented Jan 8, 2025

GaetanLepage left a comment

veprbl commented Jan 9, 2025

python3Packages.fastjet: re-init at 3.4.2.1 #370858

python3Packages.fastjet: re-init at 3.4.2.1 #370858

Conversation

veprbl commented Jan 4, 2025

Things done

lucasew commented Jan 4, 2025

nixpkgs-review result

x86_64-linux

lucasew commented Jan 4, 2025

lucasew commented Jan 4, 2025

nixpkgs-review result

x86_64-linux

veprbl commented Jan 5, 2025 • edited Loading

veprbl commented Jan 5, 2025

GaetanLepage commented Jan 5, 2025

veprbl commented Jan 5, 2025

GaetanLepage commented Jan 8, 2025

veprbl commented Jan 8, 2025

GaetanLepage commented Jan 8, 2025

nixpkgs-review result

x86_64-linux

aarch64-linux

x86_64-darwin

aarch64-darwin

veprbl commented Jan 8, 2025

GaetanLepage commented Jan 8, 2025

nixpkgs-review result

x86_64-linux

aarch64-linux

x86_64-darwin

aarch64-darwin

GaetanLepage commented Jan 8, 2025

GaetanLepage left a comment

Choose a reason for hiding this comment

veprbl commented Jan 9, 2025

`nixpkgs-review` result

`x86_64-linux`

`nixpkgs-review` result

`x86_64-linux`

veprbl commented Jan 5, 2025 •

edited

Loading

`nixpkgs-review` result

`x86_64-linux`

`aarch64-linux`

`x86_64-darwin`

`aarch64-darwin`

`nixpkgs-review` result

`x86_64-linux`

`aarch64-linux`

`x86_64-darwin`

`aarch64-darwin`