Add Module System error contexts for imports
and module argument infinite recursions
#370967
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apologies for the combined PR. They intersect at
checkConfigNotError
. Can split if desired nonetheless.This adds two new error contexts, and a little addition to the test runner.
Loading imports of module
Infinite recursion through module argument
for an example like
This has to be the fanciest error message. I am pretty confident about this error message, but I don't have proof, hence the question to report back, which self-destructs in about a year.
Everyone with an up to date Nix will see these traces, even without
--show-trace
.Dump traces
DUMP_TRACES=1
now lets us see all error traces in the test suite, including successful ones.Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.