python312Packages.altair: 5.4.1 -> 5.5.0, disable flaky tests #371464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vinetos
approved these changes
Jan 8, 2025
wegank
added
12.approvals: 1
booxter
reviewed
Jan 26, 2025
| @@ -22,7 +22,7 @@ | |||
|
|
|||
| buildPythonPackage rec { | |||
| pname = "altair"; | |||
| version = "5.4.1"; | |||
| version = "5.5.0"; | |||
| pyproject = true; | |||
|
|
|||
| disabled = pythonOlder "3.8"; | |||
There was a problem hiding this comment.
3.8 support was dropped in this version. See https://github.com/vega/altair/releases/tag/v5.5.0
So this should probably be pythonOlder "3.9"? That said, I am not sure there's a reason to have this attribute set at all, since we only have python39Packages and up. Maybe remove it?
There was a problem hiding this comment.
By my understanding we keep these seemingly useless pythonOlder statements to benefit users who mix Python 3.8 (or older) from some pinned nixpkgs version, whilst still using (some) new packages.
There was a problem hiding this comment.
@FliegendeWurst interesting. Maybe this should be clarified in python docs since it's not obvious.
FliegendeWurst
force-pushed
the
altair-5.5.0
branch
from
146a862 to
987ccd5
Compare
wegank
removed
the
12.approvals: 1
booxter
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple update
Things done