Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gittyup: fix build #371808

Closed
wants to merge 1 commit into from
Closed

gittyup: fix build #371808

wants to merge 1 commit into from

Conversation

Lilacious
Copy link
Contributor

Closes #371778

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Jan 7, 2025
@Lilacious
Copy link
Contributor Author

@GrahamcOfBorg test gittyup

@FliegendeWurst
Copy link
Member

Build still fails for me: https://paste.fliegendewurst.eu/NSliOd.log

FAILED: test/dep/zip/CMakeFiles/zip.dir/src/zip.c.o 
/nix/store/cfncx7a496zhh9f98qdzidq3shzl1an9-gcc-wrapper-14-20241116/bin/gcc -DCURR_YEAR=1980 -DDEBUG_OUTPUT_GENERAL -I/build/source/test/dep/zip/src -Wall -Wextra -Werror -pedantic -O3 -DNDEBUG -fPIC -fvisibility=hidden -MD -MT test/dep/zip/CMakeFiles/zip.dir/src/zip.c.o -MF test/dep/zip/CMakeFiles/zip.dir/src/zip.c.o.d -o test/dep/zip/CMakeFiles/zip.dir/src/zip.c.o -c /build/source/test/dep/zip/src/zip.c
In file included from /build/source/test/dep/zip/src/zip.c:39:
/build/source/test/dep/zip/src/miniz.h:4988:9: note: '#pragma message: Using fopen, ftello, fseeko, stat() etc. path for file I/O - this path may not support large files.'
 4988 | #pragma message(                                                               \
      |         ^~~~~~~
/build/source/test/dep/zip/src/zip.c: In function 'zip_stream_copy':
/build/source/test/dep/zip/src/zip.c:1676:24: error: 'calloc' sizes specified with 'sizeof' in the earlier argument and not in the later argument [-Werror=calloc-transposed-args]
 1676 |   *buf = calloc(sizeof(unsigned char), n);
      |                        ^~~~~~~~
/build/source/test/dep/zip/src/zip.c:1676:24: note: earlier argument should specify number of elements, later size of each element
cc1: all warnings being treated as errors

@phijor phijor mentioned this pull request Jan 8, 2025
13 tasks
@Lilacious Lilacious closed this Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build failure: gittyup
2 participants