Default systemd units' stopIfChanged to a smarter value #372191
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unless the unit has an ExecStop or ExecStopPost command defined, it could very easily "just" be restarted by systemd when switching configurations.
Thus, default stopIfChanged to false if the unit doesn't define either of these commands.
This change is the logical continuation of #359724, which was meant to prevent unnecessary stops/starts of
systemd-udevd
- it still does get restarted because the unit'sstopIfChanged
defaults to true, but we should probably set this to false for any unit that doesn't need it - restarting things is usually faster and disrupts service less; and sometimes it's even more correct than stopping/starting them, as in the case of udevd.Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.