Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default systemd units' stopIfChanged to a smarter value #372191

Closed

Conversation

antifuchs
Copy link
Contributor

Unless the unit has an ExecStop or ExecStopPost command defined, it could very easily "just" be restarted by systemd when switching configurations.

Thus, default stopIfChanged to false if the unit doesn't define either of these commands.

This change is the logical continuation of #359724, which was meant to prevent unnecessary stops/starts of systemd-udevd - it still does get restarted because the unit's stopIfChanged defaults to true, but we should probably set this to false for any unit that doesn't need it - restarting things is usually faster and disrupts service less; and sometimes it's even more correct than stopping/starting them, as in the case of udevd.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Unless the unit has an ExecStop or ExecStopPost command defined,
it could very easily "just" be restarted by systemd when switching
configurations.

Thus, default stopIfChanged to false if the unit doesn't define either
of these commands.
@github-actions github-actions bot added the 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS label Jan 8, 2025
@antifuchs
Copy link
Contributor Author

Sounds like this isn't going to be viable, as knowing if ExecStop is set for a unit isn't in the books for stuff like systemd.packages. Closing this, and setting stopIfChanged for the units that I know need it, then we can see about adding this to stc instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant