Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cago-hakari: 0.9.33 -> 0.9.35 #372314

Merged
merged 1 commit into from
Jan 10, 2025
Merged

cago-hakari: 0.9.33 -> 0.9.35 #372314

merged 1 commit into from
Jan 10, 2025

Conversation

jonhoo
Copy link
Contributor

@jonhoo jonhoo commented Jan 9, 2025

Is effectively an updated + squashed #371399.
Partially replaces #331244.
Fixes #371364.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@nartsisss
Copy link
Member

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 372314


aarch64-darwin

✅ 1 package built:
  • cargo-hakari

@nartsisss nartsisss added 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package labels Jan 9, 2025
@jonhoo
Copy link
Contributor Author

jonhoo commented Jan 9, 2025

@momeemt you should be able to review/approve this one instead :)

Copy link
Member

@momeemt momeemt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@momeemt momeemt added 12.approvals: 2 This PR was reviewed and approved by two reputable people and removed 12.approvals: 1 This PR was reviewed and approved by one reputable person labels Jan 10, 2025
@jonhoo
Copy link
Contributor Author

jonhoo commented Jan 10, 2025

What are the next steps to getting this merged @nartsisss ?

@nartsisss
Copy link
Member

What are the next steps to getting this merged @nartsisss ?

Waiting for a person with commit rights

@GaetanLepage
Copy link
Contributor

Can you try adding versionCheckHook and passthru.updateScript please ?

See this example:

nativeInstallCheckInputs = [
versionCheckHook
];
versionCheckProgramArg = [ "--version" ];
doInstallCheck = true;
passthru = {
updateScript = nix-update-script { };
};

@jonhoo
Copy link
Contributor Author

jonhoo commented Jan 10, 2025

I'm currently away from my computer with a working nix setup for testing, but pushed the change. Would be good if someone could give it a whirl and let me know if it doesn't work.

@GaetanLepage
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 372314


x86_64-linux

✅ 1 package built:
  • cargo-hakari

aarch64-linux

✅ 1 package built:
  • cargo-hakari

x86_64-darwin

✅ 1 package built:
  • cargo-hakari

aarch64-darwin

✅ 1 package built:
  • cargo-hakari

@GaetanLepage
Copy link
Contributor

I'm currently away from my computer with a working nix setup for testing, but pushed the change. Would be good if someone could give it a whirl and let me know if it doesn't work.

Oh I have just realized it was you ! What an honor to review your PR.

So, everything seems to build fine, on all platforms.
Could you please squash everything in a single commit named cago-hakari: 0.9.33 -> 0.9.35 ?
We should be good to merge then.

@jonhoo
Copy link
Contributor Author

jonhoo commented Jan 10, 2025

Heh, I don't know about an honour, but always fun to meet someone who values what I've put out there :)

Squashed and force-pushed 👍

Copy link
Contributor

@GaetanLepage GaetanLepage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good. Thanks for the contribution.

@GaetanLepage GaetanLepage merged commit 41871e4 into NixOS:master Jan 10, 2025
22 checks passed
@jonhoo jonhoo deleted the hakari-0.9.35 branch January 10, 2025 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12.approvals: 2 This PR was reviewed and approved by two reputable people 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update request: cargo-hakari 0.9.33 → 0.9.35
4 participants