-
-
Notifications
You must be signed in to change notification settings - Fork 14.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cago-hakari: 0.9.33 -> 0.9.35 #372314
cago-hakari: 0.9.33 -> 0.9.35 #372314
Conversation
|
@momeemt you should be able to review/approve this one instead :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What are the next steps to getting this merged @nartsisss ? |
Waiting for a person with commit rights |
Can you try adding See this example: nixpkgs/pkgs/by-name/gl/glpi-agent/package.nix Lines 118 to 126 in 97568a3
|
I'm currently away from my computer with a working nix setup for testing, but pushed the change. Would be good if someone could give it a whirl and let me know if it doesn't work. |
|
Oh I have just realized it was you ! What an honor to review your PR. So, everything seems to build fine, on all platforms. |
- <https://github.com/guppy-rs/guppy/releases/tag/cargo-hakari-0.9.34> - <https://github.com/guppy-rs/guppy/releases/tag/cargo-hakari-0.9.35> Also adds the `versionCheckHook` and `nix-update-script` passthru.
Heh, I don't know about an honour, but always fun to meet someone who values what I've put out there :) Squashed and force-pushed 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good. Thanks for the contribution.
Is effectively an updated + squashed #371399.
Partially replaces #331244.
Fixes #371364.
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.