Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python312Packages.env-canada: 0.7.2 -> 0.8.0 #372331

Merged
merged 1 commit into from
Jan 11, 2025
Merged

python312Packages.env-canada: 0.7.2 -> 0.8.0 #372331

merged 1 commit into from
Jan 11, 2025
+6 −5

Conversation

fabaff
Copy link
Member

@fabaff fabaff commented Jan 9, 2025

Diff: michaeldavie/env_canada@refs/tags/v0.7.2...v0.8.0

Changelog: https://github.com/michaeldavie/env_canada/blob/v0.8.0/CHANGELOG.md

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@momeemt
Copy link
Member

momeemt commented Jan 9, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 372331

aarch64-darwin

✅ 4 packages built:
  • python312Packages.env-canada
  • python312Packages.env-canada.dist
  • python313Packages.env-canada
  • python313Packages.env-canada.dist

@momeemt momeemt added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Jan 9, 2025
NickCao
NickCao reviewed Jan 9, 2025
View reviewed changes
Copy link
Member

@NickCao NickCao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No longer depends on defusedxml

@fabaff
Copy link
Member Author

fabaff commented Jan 11, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 372331

x86_64-linux

✅ 5 packages built:
  • home-assistant-component-tests.environment_canada
  • python312Packages.env-canada
  • python312Packages.env-canada.dist
  • python313Packages.env-canada
  • python313Packages.env-canada.dist

@fabaff fabaff merged commit 40b00ff into NixOS:master Jan 11, 2025
22 checks passed
@fabaff fabaff deleted the env-canada-bump branch January 11, 2025 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NickCao NickCao NickCao left review comments

@momeemt momeemt momeemt approved these changes

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fabaff @momeemt @NickCao