Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python313Packages.msmart-ng: 2024.12.0 -> 2025.1.0 #372358

Merged
merged 2 commits into from
Jan 9, 2025

Conversation

mweinelt
Copy link
Member

@mweinelt mweinelt commented Jan 9, 2025

https://github.com/mill1000/midea-msmart/releases/tag/2025.1.0
mill1000/midea-ac-py@2024.10.4...2025.1.1

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Copy link
Member

@emilylange emilylange left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for including links in the commit messages too! :)

Builds on x86_64-linux, reviewed the upstream diff and I don't feel like it's necessary to test against an actual device given the size and simplicity of the diffs.

Should be fine

@emilylange emilylange merged commit 8258818 into NixOS:master Jan 9, 2025
23 of 27 checks passed
@mweinelt mweinelt deleted the msmart-ng-2025.1.0 branch January 9, 2025 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants