spotify-cli-linux: 1.9.0 -> 1.9.1 #372411
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mastermines1
changed the title
NixOSInfra
added
the
12. first-time contribution
github-actions
bot
added
10.rebuild-darwin: 0
Defelo
reviewed
Jan 9, 2025
| src = fetchFromGitHub { | ||
| owner = "pwittchen"; | ||
| repo = "spotify-cli-linux"; | ||
| rev = "v${version}"; |
There was a problem hiding this comment.
Suggested change
| rev = "v${version}"; | |
| tag = "v${version}"; |
mastermines1
force-pushed
the
master
branch
2 times, most recently
from
7ce83b9 to
1f51cab
Compare
mastermines1
changed the title
Defelo
reviewed
Jan 9, 2025
mastermines1
changed the title
Also changed fetchPypi to fetchFromGitHub
|
Defelo
approved these changes
Jan 10, 2025
wegank
added
the
12.approvals: 1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update from 1.9.0 to 1.9.1 and change from fetchPypi to fetchFromGitHub.
Changelog for spotify-cli-linux:
https://github.com/pwittchen/spotify-cli-linux/releases/tag/v1.9.1
This seems to fix #372260.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.