-
-
Notifications
You must be signed in to change notification settings - Fork 14.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tmuxPlugins.tmux-which-key: init at unstable-2024-06-08 #372455
base: master
Are you sure you want to change the base?
Conversation
7163bc9
to
f8893b6
Compare
Hmm.. currently running into an issue with getting the plugin to recognize the configuration files (upstream issue); whatever the default configuration it uses works fine but any changes made seems to be ignored by the plugin. |
f8893b6
to
543b649
Compare
Ah so it turned out a home-manager module is needed in order to make changes via the nix way because the package's python script converts the yaml config file into tmux commands during derivation. See: alexwforsythe/tmux-which-key#15 (comment) Also I went and renamed it to match the name of the repository. |
543b649
to
52c72f3
Compare
lib, | ||
check-jsonschema, | ||
python3, | ||
... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
... |
mkTmuxPlugin { | ||
pluginName = "tmux-which-key"; | ||
rtpFilePath = "plugin.sh.tmux"; | ||
version = "unstable-2024-06-08"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
version = "unstable-2024-06-08"; | |
version = "0-unstable-2024-06-08"; |
Version must start with a digit.
|
||
meta = { | ||
homepage = "https://github.com/alexwforsythe/tmux-which-key"; | ||
description = "A plugin for tmux that allows users to select actions from a customizable popup menu. Inspired by vscode-which-key, emacs-which-key, and which-key.nvim"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
description = "A plugin for tmux that allows users to select actions from a customizable popup menu. Inspired by vscode-which-key, emacs-which-key, and which-key.nvim"; | |
description = "Tmux plugin that allows users to select actions from a customizable popup menu"; |
version = "unstable-2024-06-08"; | ||
propagatedBuildInputs = [ | ||
check-jsonschema | ||
(python3.withPackages (ps: with ps; [ pyyaml ])) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the plugin is a python script it might be better to patch it to use this python instead of propagating it everywhere.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You could try using patchShebangs
in postInstall and have the python env in buildInputs.
Fixes #367462
Additionally, I add myself as maintainer of the package. I tested basic functionality in my flake (as well built it with
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
) and found that it works correctly.flake info:
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.