-
-
Notifications
You must be signed in to change notification settings - Fork 14.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
plugdata: 0.8.0 -> 0.9.1 #372508
plugdata: 0.8.0 -> 0.9.1 #372508
Conversation
cc: @PowerUser64 (package maintainer) |
I can probably remove imagemagik, since we arn't converting icon sizes anymore. |
abdf246
to
c37b2fb
Compare
|
made a silly little mistake with lv2 in the install phase. |
Nice work! I'll test this out soon. |
Thank you all for your hard work! 🫡 |
Thank you for making the update request <3 |
|
Interesting, I guess it's a problem with my setup somehow? Not sure why LV2 doesn't run on my end. |
By the way, you should think about adding yourself as a maintainer to this package. There aren't many maintainers for audio applications, and you seem to have good knowledge of the things it takes to wrangle them into Nix. |
Thank you! I have a bunch more derivations written up that I need to get merged, do you mind if I request reviews from you when I open PRs for them? |
c37b2fb
to
895a0fd
Compare
Sure, go for it! I can't guarantee that I'll have time to look at everything, but I'll do what I can. Also, I'm @PowerUser64:matrix.org on Matrix if you want to message me directly about anything. |
895a0fd
to
490e124
Compare
Thanks, I'll keep that in mind. I'm @l1npengtul:matrix.org btw. |
@NixOS/nixpkgs-merge-bot merge |
@PowerUser64 merge not permitted (#305350): |
😔 |
Oh! I guess that's only for @r-ryantm PR's. mb |
license = licenses.gpl3; | ||
platforms = platforms.linux; | ||
maintainers = with maintainers; [ PowerUser64 ]; | ||
license = lib.licenses.gpl3; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Upstream does not specify GPL3-only vs. GPL3-plus. Seems okay to leave as is for now.
Updates plugdata to 0.9.1
Cleans up the nix derivation, removes a couple anti patterns.
Added auto update script.
Closes #372434.
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.