Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plugdata: 0.8.0 -> 0.9.1 #372508

Merged
merged 1 commit into from
Jan 14, 2025
Merged

Conversation

l1npengtul
Copy link
Contributor

@l1npengtul l1npengtul commented Jan 9, 2025

Updates plugdata to 0.9.1

Cleans up the nix derivation, removes a couple anti patterns.

Added auto update script.

Closes #372434.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@l1npengtul l1npengtul requested a review from PowerUser64 January 9, 2025 23:34
@l1npengtul
Copy link
Contributor Author

cc: @PowerUser64 (package maintainer)

@l1npengtul l1npengtul added the 8.has: package (update) This PR updates a package to a newer version label Jan 9, 2025
@l1npengtul
Copy link
Contributor Author

I can probably remove imagemagik, since we arn't converting icon sizes anymore.

@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Jan 9, 2025
@l1npengtul
Copy link
Contributor Author

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review


x86_64-linux

✅ 1 package built:
  • plugdata

@l1npengtul
Copy link
Contributor Author

made a silly little mistake with lv2 in the install phase.

@PowerUser64
Copy link
Contributor

Nice work! I'll test this out soon.

@AeronSor
Copy link

AeronSor commented Jan 11, 2025

Thank you all for your hard work! 🫡

@l1npengtul
Copy link
Contributor Author

l1npengtul commented Jan 11, 2025

Thank you all for your hard work! 🫡

Thank you for making the update request <3

@PowerUser64
Copy link
Contributor

Okay! I've tested this in 4 DAW's (bespoke synth, reaper, ardour, and bitwig) as well as the standalone version. Here are some notes:

  • lv2 seems to fail to load everywhere
  • reaper cannot load any version (no idea why, probably be reaper's fault)
  • bespoke cannot load the vst3 fx version
  • making a basic patch in vst3 version in bitwig has a crash when editing text (I'd guess this isn't plugdata's fault).
plugdata lv2 (instrument) plugdata lv2 (fx)
image image

If you can figure out why lv2 isn't working, that would be great. Otherwise, this is looking good!

@l1npengtul
Copy link
Contributor Author

Okay! I've tested this in 4 DAW's (bespoke synth, reaper, ardour, and bitwig) as well as the standalone version. Here are some notes:

* lv2 seems to fail to load everywhere

* reaper cannot load any version (no idea why, probably be reaper's fault)

* bespoke cannot load the vst3 fx version

* making a basic patch in vst3 version in bitwig has a crash when editing text (I'd guess this isn't plugdata's fault).

plugdata lv2 (instrument) plugdata lv2 (fx)
image image

If you can figure out why lv2 isn't working, that would be great. Otherwise, this is looking good!

image
The LV2 loads in Reaper for me, and I was able to input text in Bitwig with no crashes, may I have your configuration to be able to reproduce the issue? For reference, I am running everything on nixpkgs-unstable.

@l1npengtul
Copy link
Contributor Author

image
I can also edit text within Bitwig.

@l1npengtul
Copy link
Contributor Author

image
I can also load both plugins (VST3) within bespokesynth.

@PowerUser64
Copy link
Contributor

Interesting, I guess it's a problem with my setup somehow? Not sure why LV2 doesn't run on my end.

@PowerUser64
Copy link
Contributor

By the way, you should think about adding yourself as a maintainer to this package. There aren't many maintainers for audio applications, and you seem to have good knowledge of the things it takes to wrangle them into Nix.

@l1npengtul
Copy link
Contributor Author

By the way, you should think about adding yourself as a maintainer to this package. There aren't many maintainers for audio applications, and you seem to have good knowledge of the things it takes to wrangle them into Nix.

Thank you! I have a bunch more derivations written up that I need to get merged, do you mind if I request reviews from you when I open PRs for them?
I'll also add myself as maintainer and squash the commits now.

@PowerUser64
Copy link
Contributor

PowerUser64 commented Jan 14, 2025

do you mind if I request reviews from you when I open PRs for them?

Sure, go for it! I can't guarantee that I'll have time to look at everything, but I'll do what I can.

Also, I'm @PowerUser64:matrix.org on Matrix if you want to message me directly about anything.

@l1npengtul
Copy link
Contributor Author

do you mind if I request reviews from you when I open PRs for them?

Sure, go for it! I can't guarantee that I'll have time to look at everything, but I'll do what I can.

Also, I'm @PowerUser64:matrix.org on Matrix if you want to message me directly about anything.

Thanks, I'll keep that in mind. I'm @l1npengtul:matrix.org btw.

@PowerUser64
Copy link
Contributor

@NixOS/nixpkgs-merge-bot merge

@nixpkgs-merge-bot
Copy link
Contributor

@PowerUser64 merge not permitted (#305350):
CommitterPR: pr author is not committer
R-Ryantm Maintainer merge: pr author is not r-ryantm

@l1npengtul
Copy link
Contributor Author

😔

@PowerUser64
Copy link
Contributor

Oh! I guess that's only for @r-ryantm PR's. mb

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Jan 14, 2025
@l1npengtul l1npengtul added the 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package label Jan 14, 2025
license = licenses.gpl3;
platforms = platforms.linux;
maintainers = with maintainers; [ PowerUser64 ];
license = lib.licenses.gpl3;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upstream does not specify GPL3-only vs. GPL3-plus. Seems okay to leave as is for now.

@FliegendeWurst FliegendeWurst merged commit a5e1c93 into NixOS:master Jan 14, 2025
26 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: package (update) This PR updates a package to a newer version 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update request: plugdata 0.8.0 → 0.9.1
5 participants