Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gmrender-resurrect: 0.1 -> 0.3 #373034

Merged
merged 1 commit into from
Jan 12, 2025
Merged

gmrender-resurrect: 0.1 -> 0.3 #373034

merged 1 commit into from
Jan 12, 2025

Conversation

hzeller
Copy link
Contributor

@hzeller hzeller commented Jan 11, 2025

unbreak build: the new version compiles against modern UPnP libraries.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Jan 11, 2025
@hzeller hzeller requested a review from lromor January 11, 2025 21:24
@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Jan 12, 2025
@hzeller
Copy link
Contributor Author

hzeller commented Jan 12, 2025

Adding @FliegendeWurst as someone with merge privs.

@FliegendeWurst FliegendeWurst added 11.by: upstream-developer This issue or PR was created by the developer of packaged software 11.by: package-maintainer This PR was created by the maintainer of the package it changes labels Jan 12, 2025
@FliegendeWurst FliegendeWurst merged commit 95c346e into NixOS:master Jan 12, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FliegendeWurst FliegendeWurst FliegendeWurst approved these changes

@lromor lromor lromor approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes 11.by: upstream-developer This issue or PR was created by the developer of packaged software 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hzeller @lromor @FliegendeWurst @wegank