haskellPackages: fix build of miso/reflex deps #373056
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexfmpe
requested review from
sternenseemann and
maralorn
and removed request for
sternenseemann
github-actions
bot
added
10.rebuild-darwin: 501-1000
10.rebuild-linux: 1001-2500
labels
| doJailbreak | ||
| # Until hackage release has https://github.com/reflex-frp/reflex/pull/517 | ||
| (overrideCabal (drv: { | ||
| postPatch = "sed -i 's/Data.Witherable/Witherable/' src/Data/*.hs src/Reflex/*.hs src/Reflex/Spider/*.hs test/*.hs"; |
There was a problem hiding this comment.
- Make sure not discard any other
postPatchchanges elsewhere (hypothetic ones in this case). - Using
--replace-failis better here since it won't fail silently when the problem is fixed upstream.
This could be achieved like this (untested):
Suggested change
| postPatch = "sed -i 's/Data.Witherable/Witherable/' src/Data/*.hs src/Reflex/*.hs src/Reflex/Spider/*.hs test/*.hs"; | |
| postPatch = drv.postPatch or "" + '' | |
| substituteInPace src/Data/*.hs src/Reflex/*.hs src/Reflex/Spider/*.hs test/*.hs --replace-fail Data.Witherable Witherable | |
| '' |
There was a problem hiding this comment.
Could not use * with --replace-fail, so I listed individual files.
There was a problem hiding this comment.
Aha! That's why my own code always uses for loops with it.
alexfmpe
force-pushed
the
lts23-miso-reflex
branch
from
8b6fc1b to
aa12f81
Compare
github-actions
bot
added
10.rebuild-darwin: 11-100
10.rebuild-linux: 11-100
and removed
10.rebuild-darwin: 501-1000
10.rebuild-linux: 1001-2500
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
miso&reflexbuilds. Tested withhaskell.packages.ghc98&pkgsCross.ghcjs.haskell.packages.ghc910.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.