Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python312Packages.jsonconversion: relax numpy #373057

Merged
merged 2 commits into from
Jan 14, 2025

Conversation

fabaff
Copy link
Member

@fabaff fabaff commented Jan 11, 2025

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@fabaff

This comment was marked as outdated.

@fabaff fabaff force-pushed the jsonconversion-fix branch from 0dc1b8d to 66de219 Compare January 13, 2025 22:19
@fabaff
Copy link
Member Author

fabaff commented Jan 13, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 373057


x86_64-linux

⏩ 8 packages marked as broken and skipped:
  • python312Packages.ionhash
  • python312Packages.ionhash.dist
  • python312Packages.pyqldb
  • python312Packages.pyqldb.dist
  • python313Packages.ionhash
  • python313Packages.ionhash.dist
  • python313Packages.pyqldb
  • python313Packages.pyqldb.dist
✅ 8 packages built:
  • python312Packages.amazon-ion
  • python312Packages.amazon-ion.dist
  • python312Packages.jsonconversion
  • python312Packages.jsonconversion.dist
  • python313Packages.amazon-ion
  • python313Packages.amazon-ion.dist
  • python313Packages.jsonconversion
  • python313Packages.jsonconversion.dist

Copy link
Contributor

@terlar terlar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@wegank wegank added 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package labels Jan 14, 2025
@NickCao NickCao merged commit 4588062 into NixOS:master Jan 14, 2025
26 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.kind: build failure A package fails to build 6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants