Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bold: init at 0.1.0 #373289

Merged
merged 1 commit into from
Feb 7, 2025
Merged

bold: init at 0.1.0 #373289

merged 1 commit into from
Feb 7, 2025
+67 −0

Conversation

DimitarNestorov
Copy link
Member

@DimitarNestorov DimitarNestorov commented Jan 12, 2025 •
edited
Loading

Things done

Added https://github.com/kubkon/bold

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review

aarch64-darwin

✅ 1 package built:
  • bold
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@DimitarNestorov DimitarNestorov added the 8.has: package (new) This PR adds a new package label Jan 12, 2025
@DimitarNestorov
Copy link
Member Author

image image

Fails to build on NixOS, can't create deps.nix file due to some parse error when running zon2nix, converting to draft

@DimitarNestorov DimitarNestorov marked this pull request as draft January 12, 2025 21:50
@DimitarNestorov DimitarNestorov force-pushed the add-bold branch 2 times, most recently from 426bc55 to f4997f7 Compare January 12, 2025 22:00
@DimitarNestorov
Copy link
Member Author

DimitarNestorov commented Jan 12, 2025 •
edited
Loading

Was able to generate deps.nix with nix-community/zon2nix#22

Still not able to build on Linux:

image

Setting meta.platforms to darwin as it's also the only platform that has official releases: https://github.com/kubkon/bold/releases/tag/v0.1.0

@DimitarNestorov DimitarNestorov mentioned this pull request Jan 12, 2025
Open
@DimitarNestorov DimitarNestorov marked this pull request as ready for review January 12, 2025 22:18
@github-actions github-actions bot added 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux and removed 10.rebuild-linux: 1-10 labels Jan 12, 2025
@ethancedwards8
Copy link
Member

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 373289

aarch64-darwin

❌ 1 package failed to build:
  • bold

@ethancedwards8
Copy link
Member 

log lines:
       > Running phase: updateAutotoolsGnuConfigScriptsPhase
       > Running phase: configurePhase
       > no configure script, doing nothing
       > Running phase: buildPhase
       > zig build flags: -Dcpu=baseline --release=safe --color off
       > thread 9794443 panic: no macOS SDK found
       > /private/tmp/nix-build-bold-0.1.0.drv-0/source/test/test.zig:18:87: 0x10461542b in addTests (build)
       >     opts.macos_sdk = std.zig.system.darwin.getSdk(b.allocator, builtin.target) orelse @panic("no macOS SDK found");
       >                                                                                       ^
       > /private/tmp/nix-build-bold-0.1.0.drv-0/source/build.zig:98:38: 0x1045d9e17 in build (build)
       >     test_step.dependOn(tests.addTests(b, exe, .{
       >                                      ^
       > /nix/store/cjga11fv11521652y515qv5kisvn889p-zig-0.13.0/lib/zig/std/Build.zig:2116:33: 0x1045be757 in runBuild__anon_8412 (build)
       >         .Void => build_zig.build(b),
       >                                 ^
       > /nix/store/cjga11fv11521652y515qv5kisvn889p-zig-0.13.0/lib/zig/compiler/build_runner.zig:301:29: 0x1045b96b7 in main (build)
       >         try builder.runBuild(root);
       >                             ^
       > /nix/store/cjga11fv11521652y515qv5kisvn889p-zig-0.13.0/lib/zig/std/start.zig:524:37: 0x1045c0d9b in main (build)
       >             const result = root.main() catch |err| {
       >                                     ^
       > ???:?:?: 0x187aa0273 in ??? (???)
       > ???:?:?: 0x0 in ??? (???)
       > error: the following build command crashed:
       > /private/tmp/nix-build-bold-0.1.0.drv-0/source/.zig-cache/o/c0bc9a606919549c09832a94a68872d6/build /nix/store/cjga11fv11521652y515qv5kisvn889p-zig-0.13.0/bin/zig /private/tmp/nix-build-bold-0.1.0.drv-0/source /private/tmp/nix-build-bold-0.1.0.drv-0/source/.zig-cache /private/tmp/nix-build-bold-0.1.0.drv-0/tmp.Mw7yO8ULme --seed 0x3cb41dd5 -Z086dcd204f351df0 -Dcpu=baseline --release=safe --color off
       For full logs, run 'nix log /nix/store/3fdxxqfl90p7c7dlki23r45sl3blx1jy-bold-0.1.0.drv'.
error: 1 dependencies of derivation '/nix/store/8ry2qjkd80jmfaf8szab0cxn7wa5fpgh-review-shell.drv' failed to build

@DimitarNestorov
Copy link
Member Author

@ethancedwards8 can you try again? I tried it on a fresh VM with no Xcode Command Line Tools and it's still working fine for me.

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review

aarch64-darwin

✅ 1 package built:
  • bold

@GaetanLepage
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 373289

x86_64-darwin

❌ 1 package failed to build:
  • bold

aarch64-darwin

❌ 1 package failed to build:
  • bold

@GaetanLepage
Copy link
Contributor 

thread 38949807 panic: no macOS SDK found
/private/tmp/nix-build-bold-0.1.0.drv-1/source/test/test.zig:18:87: 0x104d356ef in addTests (build)
    opts.macos_sdk = std.zig.system.darwin.getSdk(b.allocator, builtin.target) orelse @panic("no macOS SDK found");
                                                                                      ^
/private/tmp/nix-build-bold-0.1.0.drv-1/source/build.zig:98:38: 0x104cf9f97 in build (build)
    test_step.dependOn(tests.addTests(b, exe, .{
                                     ^
/nix/store/cjga11fv11521652y515qv5kisvn889p-zig-0.13.0/lib/zig/std/Build.zig:2116:33: 0x104cde87b in runBuild__anon_8412 (build)
        .Void => build_zig.build(b),
                                ^
/nix/store/cjga11fv11521652y515qv5kisvn889p-zig-0.13.0/lib/zig/compiler/build_runner.zig:301:29: 0x104cd97d7 in main (build)
        try builder.runBuild(root);
                            ^
/nix/store/cjga11fv11521652y515qv5kisvn889p-zig-0.13.0/lib/zig/std/start.zig:524:37: 0x104ce0ebf in main (build)
            const result = root.main() catch |err| {
                                    ^
???:?:?: 0x18cbc0273 in ??? (???)
???:?:?: 0x985bffffffffffff in ??? (???)

@niklaskorz niklaskorz mentioned this pull request Jan 24, 2025
Merged
13 tasks
@niklaskorz
Copy link
Contributor

Darwin sandbox build failure is addressed by #376427

@DimitarNestorov
Copy link
Member Author

Now that #376427 is merged building this in sandbox seems to work, I've enabled sandboxing and it works on my machine. Thank you Niklas! Please check again @GaetanLepage @ethancedwards8

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review

aarch64-darwin

✅ 1 package built:
  • bold

GaetanLepage
GaetanLepage approved these changes Feb 7, 2025
View reviewed changes
Copy link
Contributor

@GaetanLepage GaetanLepage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks !

@DimitarNestorov DimitarNestorov added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Feb 7, 2025
@niklaskorz
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 373289

x86_64-darwin

✅ 1 package built:
  • bold

@DimitarNestorov DimitarNestorov added 12.approvals: 2 This PR was reviewed and approved by two reputable people and removed 12.approvals: 1 This PR was reviewed and approved by one reputable person labels Feb 7, 2025
@GaetanLepage
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 373289

x86_64-darwin

✅ 1 package built:
  • bold

aarch64-darwin

✅ 1 package built:
  • bold

@GaetanLepage GaetanLepage merged commit d98abf5 into NixOS:master Feb 7, 2025
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@niklaskorz niklaskorz niklaskorz approved these changes

@GaetanLepage GaetanLepage GaetanLepage approved these changes

Assignees
No one assigned
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux 12.approvals: 2 This PR was reviewed and approved by two reputable people
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@DimitarNestorov @ethancedwards8 @GaetanLepage @niklaskorz