Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

roslyn-ls: 4.13.0-3.24577.4 -> 4.13.0-3.25051.1 #373293

Merged
merged 1 commit into from
Jan 13, 2025
Merged

roslyn-ls: 4.13.0-3.24577.4 -> 4.13.0-3.25051.1 #373293

merged 1 commit into from
Jan 13, 2025

Conversation

konradmalik
Copy link
Contributor

@konradmalik konradmalik commented Jan 12, 2025 •
edited by corngood
Loading

Added a git-patch to drop net6.0 dependency, which is now EOL.
See #372476 (comment)

Tested the basic functionality in Neovim - seems to work as normal.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@konradmalik konradmalik force-pushed the roslyn-ls branch 2 times, most recently from b5473e6 to c560586 Compare January 12, 2025 21:48
@konradmalik
roslyn-ls: 4.13.0-3.24577.4 -> 4.13.0-3.25051.1
d9b2b97 
Added a git-patch to drop net6.0 dependency, which is now EOL.
See NixOS#372476 (comment)
@konradmalik konradmalik marked this pull request as ready for review January 13, 2025 08:45
@konradmalik konradmalik mentioned this pull request Jan 13, 2025
Closed
13 tasks
@corngood corngood added the backport release-24.11 Backport PR automatically label Jan 13, 2025
@corngood
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 373293

x86_64-linux

✅ 1 package built:
  • roslyn-ls

@konradmalik
Copy link
Contributor Author

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 373293

x86_64-darwin

✅ 1 package built:
  • roslyn-ls

@konradmalik konradmalik added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 1 This PR was reviewed and approved by one reputable person 8.has: package (update) This PR updates a package to a newer version labels Jan 13, 2025
@corngood corngood self-assigned this Jan 13, 2025
@FliegendeWurst FliegendeWurst merged commit ba9f794 into NixOS:master Jan 13, 2025
71 of 74 checks passed
@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented Jan 13, 2025

Successfully created backport PR for release-24.11:

@nixpkgs-ci nixpkgs-ci bot mentioned this pull request Jan 13, 2025
Merged
1 task
@tris203 tris203 mentioned this pull request Jan 13, 2025
Open
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corngood corngood corngood approved these changes

@GGG-KILLER GGG-KILLER Awaiting requested review from GGG-KILLER

Assignees

@corngood corngood

Labels
8.has: package (update) This PR updates a package to a newer version 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 1 This PR was reviewed and approved by one reputable person backport release-24.11 Backport PR automatically
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@konradmalik @corngood @FliegendeWurst