-
-
Notifications
You must be signed in to change notification settings - Fork 14.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bzip2: Embed autoconf patch #373337
Open
Dietr1ch
wants to merge
1
commit into
NixOS:staging
Choose a base branch
from
Dietr1ch:dev/bzip2-autoconf
base: staging
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
bzip2: Embed autoconf patch #373337
+371
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Please rebase to staging following these instructions: https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md#rebasing-between-branches-ie-from-master-to-staging |
Dietr1ch
force-pushed
the
dev/bzip2-autoconf
branch
from
January 13, 2025 13:17
3d200f5
to
50aacf1
Compare
I'm seeing consistent failures trying to get the patch using ftp:// and it seems that the https:// download fails under IPv6-only connectivity. NixOS#272640 With this, it seems that just grabbing the patch is the best option around as suggested by jshort, NixOS#272640 (comment)
Dietr1ch
force-pushed
the
dev/bzip2-autoconf
branch
from
January 13, 2025 14:31
50aacf1
to
e11fc0b
Compare
github-actions
bot
added
6.topic: python
6.topic: nixos
Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS
6.topic: haskell
6.topic: qt/kde
6.topic: kernel
The Linux kernel
8.has: documentation
This PR adds or changes documentation
8.has: changelog
8.has: module (update)
This PR changes an existing module in `nixos/`
6.topic: emacs
Text editor
6.topic: rust
6.topic: golang
6.topic: vim
6.topic: erlang
6.topic: ocaml
6.topic: fetch
6.topic: stdenv
Standard environment
6.topic: nodejs
6.topic: TeX
Issues regarding texlive and TeX in general
6.topic: systemd
6.topic: julia
8.has: maintainer-list (update)
This PR changes `maintainers/maintainer-list.nix`
6.topic: llvm/clang
Issues related to llvmPackages, clangStdenv and related
6.topic: dotnet
Language: .NET
labels
Jan 13, 2025
The PR's base branch is set to master, but 1171 commits from the staging branch are included. Make sure you know the right base branch for your changes, then:
|
github-actions
bot
removed
6.topic: python
6.topic: nixos
Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS
6.topic: haskell
6.topic: qt/kde
6.topic: kernel
The Linux kernel
8.has: documentation
This PR adds or changes documentation
8.has: changelog
8.has: module (update)
This PR changes an existing module in `nixos/`
6.topic: emacs
Text editor
6.topic: rust
6.topic: golang
6.topic: vim
6.topic: erlang
6.topic: ocaml
6.topic: fetch
6.topic: stdenv
Standard environment
6.topic: nodejs
6.topic: TeX
Issues regarding texlive and TeX in general
6.topic: systemd
6.topic: julia
8.has: maintainer-list (update)
This PR changes `maintainers/maintainer-list.nix`
6.topic: llvm/clang
Issues related to llvmPackages, clangStdenv and related
6.topic: dotnet
Language: .NET
6.topic: flutter
6.topic: nvidia
labels
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm seeing consistent failures trying to get the patch using
ftp://
and it seems that thehttps://
download fails under IPv6-only connectivity (#272640)With this, it seems that just grabbing the patch is the best option around as suggested in the thread, #272640 (comment)
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.