mitmproxy: 11.0.2 -> 11.1.0; mitmproxy-linux: init at 0.11.4 #373425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't know why mitmproxy pulling old version of mitmproxy |
SuperSandro2000
requested changes
Jan 13, 2025
|
@SuperSandro2000 mitmproxy seperated linux part to mitmproxy-linux like mitmproxy-macos, I want to hear your opinion.
|
|
If mitmproxy-rs is unused in tree then we don't need it and should delete it. |
MisileLab
changed the title
|
mitmproxy-linux requires rust-src, how can I add it? full log |
|
pkgs/top-level/python-aliases.nix
Outdated
| @@ -370,7 +370,8 @@ mapAliases ({ | |||
| mir_eval = mir-eval; # added 2024-01-07 | |||
| mistune_0_8 = throw "mistune_0_8 was removed because it was outdated and insecure"; # added 2022-08-12 | |||
| mistune_2_0 = mistune; # added 2022-08-12 | |||
| mitmproxy-wireguard = throw "mitmproxy-wireguard has been removed because it was replaced by upstream with mitmproxy-rs"; # added 2023-11-06 | |||
| mitmproxy = throw "mitmproxy has been removed because it was replaced by mitmproxy-linux and mitmproxy-macos"; # added 2025-01-16 | |||
There was a problem hiding this comment.
Suggested change
| mitmproxy = throw "mitmproxy has been removed because it was replaced by mitmproxy-linux and mitmproxy-macos"; # added 2025-01-16 | |
| mitmproxy-rs = throw "mitmproxy-rs has been removed because it was replaced by mitmproxy-linux and mitmproxy-macos"; # added 2025-01-16 |
I don't see an env how to point it to that. Also so far I couldn't figure out which step exactly wants the src but the source will be in rustPlatform.rustLibSrc |
|
I think aya-ebpf might be causing the rust nightly dependency. https://github.com/aya-rs/aya not sure what to do here. |
|
maybe we can fetch from https://pypi.org/project/mitmproxy-linux like mitmproxy-macos |
I looked rust doc and it says -Z build-std needs nightly version of rustc, rust-src and cargo. |
Signed-off-by: misilelab <[email protected]>
|
I tried patching that out earlier but we should try it again more aggressively. If that doesn't work we just fetch it from nine source if possible |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/mitmproxy/mitmproxy/blob/v11.1.0/CHANGELOG.md
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.